Bugzilla – Attachment 114577 Details for
Bug 26171
Show biblionumber in Koha::Exceptions::Metadata::Invalid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26171: (QA follow-up) Add table name and object type to message
Bug-26171-QA-follow-up-Add-table-name-and-object-t.patch (text/plain), 1.92 KB, created by
Nick Clemens (kidclamp)
on 2020-12-21 19:25:38 UTC
(
hide
)
Description:
Bug 26171: (QA follow-up) Add table name and object type to message
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-12-21 19:25:38 UTC
Size:
1.92 KB
patch
obsolete
>From def0bf2a2bb462f22ccc342268f7ee3885838397 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 21 Dec 2020 19:24:05 +0000 >Subject: [PATCH] Bug 26171: (QA follow-up) Add table name and object type to > message > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/Exceptions/Metadata.pm | 2 +- > t/Koha/Exceptions.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Exceptions/Metadata.pm b/Koha/Exceptions/Metadata.pm >index 78dadae348..8c95fa0556 100644 >--- a/Koha/Exceptions/Metadata.pm >+++ b/Koha/Exceptions/Metadata.pm >@@ -36,7 +36,7 @@ sub full_message { > > unless ($msg) { > if ( $self->isa('Koha::Exceptions::Metadata::Invalid') ) { >- $msg = sprintf( "Invalid data, cannot decode object (id=%s, biblionumber=%s, format=%s, schema=%s, decoding_error='%s')", >+ $msg = sprintf( "Invalid data, cannot decode metadata object (biblio_metadata.id=%s, biblionumber=%s, format=%s, schema=%s, decoding_error='%s')", > $self->id, $self->biblionumber, $self->format, $self->schema, $self->decoding_error ); > } > } >diff --git a/t/Koha/Exceptions.t b/t/Koha/Exceptions.t >index 1a98779429..5cd3f1cfff 100755 >--- a/t/Koha/Exceptions.t >+++ b/t/Koha/Exceptions.t >@@ -123,7 +123,7 @@ subtest 'Koha::Exceptions::Metadata tests' => sub { > 'Exception is thrown :-D'; > > # stringify the exception >- is( "$@", 'Invalid data, cannot decode object (id=an_id, biblionumber=a_biblionumber, format=a_format, schema=a_schema, decoding_error=\'a_nasty_error\')', 'Exception stringified correctly' ); >+ is( "$@", 'Invalid data, cannot decode metadata object (biblio_metadata.id=an_id, biblionumber=a_biblionumber, format=a_format, schema=a_schema, decoding_error=\'a_nasty_error\')', 'Exception stringified correctly' ); > > throws_ok > { Koha::Exceptions::Metadata::Invalid->throw( "Manual message exception" ) } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26171
:
107941
|
107944
|
114050
|
114051
|
114575
|
114576
| 114577