Attachment 11471 Details for Bug 5327 – [SIGNED-OFF] Bug 5327 Tests for C4::Matcher

[patch] [SIGNED-OFF] Bug 5327 Tests for C4::Matcher

SIGNED-OFF-Bug-5327-Tests-for-C4Matcher.patch (text/plain), 2.24 KB, created by Katrin Fischer on 2012-08-09 05:24:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2012-08-09 05:24:57 UTC

Size: 2.24 KB

patch

obsolete

>From 4f173f17e716ae50393c0019e59d61b4592e2bbd Mon Sep 17 00:00:00 2001
>From: Bart Jorgensen <bart.tj@gmail.com>
>Date: Thu, 2 Aug 2012 16:56:58 +1200
>Subject: [PATCH] [SIGNED-OFF] Bug 5327 Tests for C4::Matcher
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>---
> t/Matcher.t |   54 +++++++++++++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 51 insertions(+), 3 deletions(-)
>
>diff --git a/t/Matcher.t b/t/Matcher.t
>index f374877..c0caf50 100755
>--- a/t/Matcher.t
>+++ b/t/Matcher.t
>@@ -1,14 +1,62 @@
> #!/usr/bin/perl
> #
>-# This Koha test module is a stub!  
>-# Add more tests here!!!
>+#testing C4 matcher
> 
> use strict;
> use warnings;
>+use Test::More tests => 10;
>+use Test::MockModule;
>+
> 
>-use Test::More tests => 1;
> 
> BEGIN {
>         use_ok('C4::Matcher');
> }
> 
>+my $module = new Test::MockModule('C4::Context');
>+$module->mock('_new_dbh', sub {
>+                             my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
>+                             || die "Cannot create handle: $DBI::errstr\n";
>+                             return $dbh });
>+my $matcher = [
>+    ['matcher_id','code','description','record_type','threshold'],
>+    [1,'ISBN','ISBN','red',1],
>+    [2,'ISSN','ISSN','blue',0]
>+    ];
>+my $dbh = C4::Context->dbh();
>+
>+$dbh->{mock_add_resultset} = $matcher;
>+
>+my @matchers = C4::Matcher::GetMatcherList();
>+
>+is($matchers[0]->{'matcher_id'},1, 'First matcher_id value is 1');
>+
>+is($matchers[1]->{'matcher_id'},2, 'Second matcher_id value is 2');
>+
>+$dbh->{mock_add_resultset} = $matcher;
>+
>+my $matcher_id = C4::Matcher::GetMatcherId('ISBN');
>+
>+is($matcher_id,1,'testing getmatcherid');
>+
>+my $testmatcher;
>+
>+ok($testmatcher = C4::Matcher->new('red', 1), 'testing matcher new');
>+
>+ok($testmatcher = C4::Matcher->new('blue', 0), 'testing matcher new');
>+
>+$testmatcher->threshold(1000);
>+
>+is($testmatcher->threshold(),1000, 'testing threshhold accessor method');
>+
>+$testmatcher->_id(53);
>+
>+is($testmatcher->_id(),53, 'testing _id accessor');
>+
>+$testmatcher->code('match on ISBN');
>+
>+is($testmatcher->code(),'match on ISBN', 'testing code accessor');
>+
>+$testmatcher->description('match on ISSN');
>+
>+is($testmatcher->description(),'match on ISSN', 'testing code accessor');
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 5327: 2716 | 2726 | 5485 | 6236 | 6237 | 6373 | 6560 | 6561 | 6562 | 6563 | 6613 | 6614 | 6616 | 6620 | 6621 | 6622 | 6643 | 6650 | 6655 | 6679 | 6681 | 6682 | 6683 | 6726 | 6727 | 6728 | 6729 | 6730 | 6731 | 6732 | 6795 | 6799 | 6805 | 6819 | 6826 | 6827 | 6828 | 6834 | 7179 | 7180 | 7181 | 7182 | 7183 | 7184 | 7185 | 7186 | 7187 | 7188 | 7189 | 7190 | 7191 | 7192 | 7194 | 7195 | 7203 | 7206 | 7208 | 7209 | 7220 | 7221 | 7222 | 7223 | 7224 | 7225 | 7226 | 7227 | 7228 | 7229 | 7230 | 7231 | 7232 | 7233 | 7234 | 7235 | 7236 | 7237 | 7238 | 7239 | 7240 | 7241 | 7242 | 7400 | 7402 | 7403 | 7405 | 7573 | 7592 | 7593 | 7594 | 9897 | 10234 | 10616 | 10656 | 10659 | 10660 | 10661 | 10680 | 11141 | 11186 | 11212 | 11213 | 11278 | 11279 | 11280 | 11281 | 11339 | 11340 | 11341 | 11440 | 11467 | 11469 | 11470 | 11471 | 11472 | 11473 | 11500 | 11503 | 11505 | 11506 | 11633 | 11762 | 11763 | 11764 | 11765 | 11846 | 11985 | 11993 | 12002 | 12003