Attachment 114726 Details for Bug 26847 – Bug 26847: Add UI test for categorycode in masthead

[patch] Bug 26847: Add UI test for categorycode in masthead

Bug-26847-Add-UI-test-for-categorycode-in-masthead.patch (text/plain), 1.70 KB, created by Victor Grousset/tuxayo on 2020-12-29 16:07:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2020-12-29 16:07:20 UTC

Size: 1.70 KB

patch

obsolete

>From d117c64d53b437665626655162c12cd496d27711 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 4 Nov 2020 14:45:27 +0000
>Subject: [PATCH] Bug 26847: Add UI test for categorycode in masthead
>
>This test adds a regression test for the addition of categorycode
>into the masthead of the staff client.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> t/db_dependent/selenium/regressions.t | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t
>index c18c95a837..1350f2ea15 100755
>--- a/t/db_dependent/selenium/regressions.t
>+++ b/t/db_dependent/selenium/regressions.t
>@@ -49,8 +49,8 @@ my $AudioAlerts_value = C4::Context->preference('AudioAlerts');
> C4::Context->set_preference('AudioAlerts', '1');
> 
> our @cleanup;
>-subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub {
>-    plan tests => 2;
>+subtest 'OPAC - borrowernumber, branchcode and categorycode as html attributes' => sub {
>+    plan tests => 3;
> 
>     my $patron = $builder->build_object(
>         { class => 'Koha::Patrons', value => { flags => 1 } } );
>@@ -64,6 +64,9 @@ subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub {
>     );
>     is( $elt->get_attribute('data-borrowernumber'), $patron->borrowernumber,
> "Since bug 20921 span.loggedinusername should contain data-borrowernumber"
>+    );
>+    is( $elt->get_attribute('data-categorycode'), $patron->categorycode,
>+"Since bug 26847 span.loggedinusername should contain data-categorycode"
>     );
>     push @cleanup, $patron, $patron->category, $patron->library;
> };
>-- 
>2.29.2

Actions: View | Diff | Splinter Review

Attachments on bug 26847: 113003 | 113004 | 113012 | 113013 | 114726 | 114727 | 114872