Bugzilla – Attachment 114743 Details for
Bug 27316
In mappings use yes/no for sortable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27316: In Elasticsearch mappings use yes/no for sortable
Bug-27316-In-Elasticsearch-mappings-use-yesno-for-.patch (text/plain), 3.06 KB, created by
Fridolin Somers
on 2020-12-30 13:39:25 UTC
(
hide
)
Description:
Bug 27316: In Elasticsearch mappings use yes/no for sortable
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2020-12-30 13:39:25 UTC
Size:
3.06 KB
patch
obsolete
>From 3e3fed164a24b384eefbf31591957c70f18fe484 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 30 Dec 2020 14:33:44 +0100 >Subject: [PATCH] Bug 27316: In Elasticsearch mappings use yes/no for sortable > >In search engine configuration (Elasticsearch), there is a colum 'sortable'. >It contains 'Undef', 0 or 1. >0 and 1 are not really friendly values for a boolean. >And also the translation seems to replace 0 by empty string (seen in fr-FR translation). > >I propose to replace by Yes/No like other boolean. > >Test plan : >1) Without patch, look at Administration > Search engine configuration (Elasticsearch) >2) Look at tab 'Bibliographic records' >3) Look at a row containing 0 and a row containing 1 >4) Apply patch >5) Refresh page >6) Check 0 is now 'No' and 1 is now 'Yes' >7) Check creating a new row with 'Yes' or 'No' >--- > .../admin/searchengine/elasticsearch/mappings.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >index bd726dacca..580a069d5a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >@@ -336,14 +336,14 @@ a.add, a.delete { > <option value="undef">Undef</option> > [% END %] > [% IF mapping.sort == 0 %] >- <option value="0" selected="selected">0</option> >+ <option value="0" selected="selected">No</option> > [% ELSE %] >- <option value="0">0</option> >+ <option value="0">No</option> > [% END %] > [% IF mapping.sort == 1 %] >- <option value="1" selected="selected">1</option> >+ <option value="1" selected="selected">Yes</option> > [% ELSE %] >- <option value="1">1</option> >+ <option value="1">Yes</option> > [% END %] > </select> > </td> >@@ -410,8 +410,8 @@ a.add, a.delete { > <td> > <select data-id="mapping_sort"> > <option value="undef">Undef</option> >- <option value="0">0</option> >- <option value="1">1</option> >+ <option value="0">No</option> >+ <option value="1">Yes</option> > </select> > </td> > <td> >-- >2.29.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27316
:
114743
|
114752
|
114943
|
114955
|
115938
|
115939
|
117429
|
117430