Attachment 114761 Details for Bug 27321 – Bug 27321: make disabled labels #cccccc

[patch] Bug 27321: make disabled labels #cccccc

Bug-27321-make-disabled-labels-cccccc.patch (text/plain), 2.05 KB, created by Lucas Gass (lukeg) on 2020-12-31 15:41:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2020-12-31 15:41:52 UTC

Size: 2.05 KB

patch

obsolete

>From 077b3b25bb63e614d3cf8ca48bfef2f37e69e374 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 31 Dec 2020 15:36:39 +0000
>Subject: [PATCH] Bug 27321: make disabled labels #cccccc
>
>To test:
>1. Apply patch and its dependency (bug 17364)
>2. Go the system pref BorroweUnwantedFields
>3. branchcode should cleary stand out as disabled (#cccccc)
>---
> koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
>index c25854b619..9e1718f0c9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
>@@ -233,6 +233,7 @@ $( document ).ready( function () {
>         $.getJSON( themelang + "/modules/admin/preferences/" + datasource + ".json", function( data ){
>             var items = [];
>             var checked = "";
>+            var style = "";
>             $.each( data, function( key, val ){
>                 if( prefs.indexOf( val ) >= 0 ){
>                     checked = ' checked="checked" ';
>@@ -240,12 +241,14 @@ $( document ).ready( function () {
>                     checked = "";
>                 }
>                 if( exclusions.indexOf( val ) >= 0 ){
>+                    style = ' style="color:#cccccc;" ';
>                     disabled = ' disabled="disabled" ';
>                     checked  = "";
>                 } else {
>+                    style = ' style="color:#000;" '; 
>                     disabled = "";
>                 }
>-                items.push('<label><input class="dbcolumn_selection" type="checkbox" id="' + key + '"' + checked + disabled + ' name="pref" value="' + val + '" /> ' + key + '</label>');
>+                items.push('<label' + style +'><input class="dbcolumn_selection" type="checkbox" id="' + key + '"' + checked + disabled + ' name="pref" value="' + val + '" /> ' + key + '</label>');
>             });
>             $("<div/>", {
>                 "class": "columns-2",
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27321: 114761 | 114763 | 115045 | 115103 | 116088 | 116118