Bugzilla – Attachment 114818 Details for
Bug 26364
XISBN.t makes a bad assumption about return values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26364: Don't skip records that match the isbn we passed
Bug-26364-Dont-skip-records-that-match-the-isbn-we.patch (text/plain), 921 bytes, created by
Katrin Fischer
on 2021-01-04 22:18:00 UTC
(
hide
)
Description:
Bug 26364: Don't skip records that match the isbn we passed
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-01-04 22:18:00 UTC
Size:
921 bytes
patch
obsolete
>From cb09f0906f113282f6ea0ae48e075ebd20cd4f65 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 9 Sep 2020 13:24:20 +0000 >Subject: [PATCH] Bug 26364: Don't skip records that match the isbn we passed > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/XISBN.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/XISBN.pm b/C4/XISBN.pm >index de9dc100fe..6f7c3bf4bc 100644 >--- a/C4/XISBN.pm >+++ b/C4/XISBN.pm >@@ -107,7 +107,6 @@ sub get_xisbns { > $unique_xisbns->{ $response_data->{content} }++; > my $xbiblio= _get_biblio_from_xisbn($response_data->{content}); > next unless $xbiblio; >- next if $xbiblio->{normalized_isbn} && $xbiblio->{normalized_isbn} eq $isbn; > push @xisbns, $xbiblio if $xbiblio && $xbiblio->{biblionumber} ne $biblionumber; > } > if ( wantarray ) { >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=114818">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26364
:
109599
|
109631
|
109821
|
109822
|
109823
|
109824
|
109825
|
113054
|
113055
|
113056
|
113057
|
113058
| 114818 |
114819
|
114820
|
114821
|
114822