Bugzilla – Attachment 11483 Details for
Bug 8606
Talking Tech broken by user-configurable slips feature
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8606 - Talking Tech broken by Bug 7001
Bug-8606---Talking-Tech-broken-by-Bug-7001.patch (text/plain), 2.53 KB, created by
Kyle M Hall (khall)
on 2012-08-09 11:58:44 UTC
(
hide
)
Description:
Bug 8606 - Talking Tech broken by Bug 7001
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-08-09 11:58:44 UTC
Size:
2.53 KB
patch
obsolete
>From 0373eb1b458100ef96ecb340b46b5c8b3a916144 Mon Sep 17 00:00:00 2001 >From: Koha user <koha@mtpl.bywatersolutions.com> >Date: Tue, 7 Aug 2012 08:09:19 -0400 >Subject: [PATCH] Bug 8606 - Talking Tech broken by Bug 7001 > >The patches for bug 7001 removed the parseletter subroutine from >C4::Letters without updating the talking tech script to use the >new alternative. This patch rectifies that situation. >--- > C4/Letters.pm | 3 ++ > .../thirdparty/TalkingTech_itiva_outbound.pl | 23 ++++++++----------- > 2 files changed, 13 insertions(+), 13 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index b17cb08..5186eac 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -120,9 +120,12 @@ my %letter; > sub getletter { > my ( $module, $code, $branchcode ) = @_; > >+ $branchcode |= ''; >+ > if ( C4::Context->preference('IndependantBranches') > and $branchcode > and C4::Context->userenv ) { >+ > $branchcode = C4::Context->userenv->{'branch'}; > } > >diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >index 226f17e..b4d4e9c 100755 >--- a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >+++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >@@ -127,20 +127,17 @@ foreach my $type (@types) { > my $date = C4::Dates->new( $issues->{'date_due'}, 'iso' ); > my $due_date = $date->output('metric'); > >- # gets the placeholder message, and enqueues the letter >- my $letter = getletter( $module, $code ); >- die "No letter found for type $type!... dying\n" unless $letter; >+ my $letter = C4::Letters::GetPreparedLetter( >+ module => $module, >+ letter_code => $code, >+ tables => { >+ borrowers => $issues->{'borrowernumber'}, >+ biblio => $issues->{'biblionumber'}, >+ biblioitems => $issues->{'biblionumber'} >+ }, >+ ); > >- # covers basic variable parsing in letter >- $letter = >- C4::Letters::parseletter( $letter, 'borrowers', >- $issues->{'borrowernumber'} ); >- $letter = >- C4::Letters::parseletter( $letter, 'biblio', >- $issues->{'biblionumber'} ); >- $letter = >- C4::Letters::parseletter( $letter, 'biblioitems', >- $issues->{'biblionumber'} ); >+ die "No letter found for type $type!... dying\n" unless $letter; > > my $message_id = 0; > if ($outfile) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8606
:
11482
|
11483
|
11830
|
12359
|
12360