Attachment 114872 Details for Bug 26847 – Bug 26847: (follow-up) fix get_attribute() call

[patch] Bug 26847: (follow-up) fix get_attribute() call

Bug-26847-follow-up-fix-getattribute-call.patch (text/plain), 1.27 KB, created by Victor Grousset/tuxayo on 2021-01-05 13:25:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2021-01-05 13:25:12 UTC

Size: 1.27 KB

patch

obsolete

>From 665697a032239c20b968f9a29de5d25f1f055eef Mon Sep 17 00:00:00 2001
>From: Victor Grousset/tuxayo <victor@tuxayo.net>
>Date: Tue, 5 Jan 2021 13:56:32 +0100
>Subject: [PATCH] Bug 26847: (follow-up) fix get_attribute() call
>
>Since the upgrade to Selenium 3 in bug 27055, an additional parameter is
>required for get_attribute() to actually work.
>https://metacpan.org/pod/Selenium::Remote::WebElement#get_attribute
>---
> t/db_dependent/selenium/regressions.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t
>index 3a3a7cb186..141bd45f2d 100755
>--- a/t/db_dependent/selenium/regressions.t
>+++ b/t/db_dependent/selenium/regressions.t
>@@ -67,7 +67,7 @@ subtest 'OPAC - borrowernumber, branchcode and categorycode as html attributes'
>     is( $elt->get_attribute('data-borrowernumber', 1), $patron->borrowernumber,
> "Since bug 20921 span.loggedinusername should contain data-borrowernumber"
>     );
>-    is( $elt->get_attribute('data-categorycode'), $patron->categorycode,
>+    is( $elt->get_attribute('data-categorycode', 1), $patron->categorycode,
> "Since bug 26847 span.loggedinusername should contain data-categorycode"
>     );
>     push @cleanup, $patron, $patron->category, $patron->library;
>-- 
>2.29.2

Actions: View | Diff | Splinter Review

Attachments on bug 26847: 113003 | 113004 | 113012 | 113013 | 114726 | 114727 | 114872