Attachment 114898 Details for Bug 25808 – Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message

[patch] Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message

Bug-25808-Renewal-via-the-SIP-checkout-message-giv.patch (text/plain), 1.92 KB, created by Martin Renvoize (ashimema) on 2021-01-06 16:32:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-01-06 16:32:01 UTC

Size: 1.92 KB

patch

obsolete

>From a05d33e868d00632336436dadde0ffdf216eac5b Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 18 Jun 2020 13:23:04 -0400
>Subject: [PATCH] Bug 25808: Renewal via the SIP 'checkout' message gives
> incorrect message
>
>If a renewal via SIP cannot be made because the patron has reached the maximum number of renewals,
>the AF screen message should read "Item has reached maximum renewals!",
>instead we get "Item checked out to another patron".
>
>Test Plan:
>1) Check out an item to a patron
>2) Using the SIP CLI tool, run checkout messages until the checkout has
>   reached the maximum number of renewals
>3) Note the incorrect message in the AF field
>4) Apply this patch
>5) Restart the SIP server
>6) Run another SIP checkout message
>7) Note the message is now correct!
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/SIP/ILS.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm
>index d2a253873b..f74045319c 100644
>--- a/C4/SIP/ILS.pm
>+++ b/C4/SIP/ILS.pm
>@@ -148,7 +148,7 @@ sub checkout {
>         $circ->screen_msg("Invalid Item");
>     }
>     elsif ( $item->{borrowernumber}
>-        && !_ci_cardnumber_cmp( $item->{borrowernumber}, $patron_id ) )
>+        && !_ci_cardnumber_cmp( $item->{borrowernumber}, $patron->borrowernumber ) )
>     {
>         $circ->screen_msg("Item checked out to another patron");
>     }
>@@ -160,7 +160,7 @@ sub checkout {
>             # If the item is already associated with this patron, then
>             # we're renewing it.
>             $circ->renew_ok( $item->{borrowernumber}
>-                  && _ci_cardnumber_cmp( $item->{borrowernumber}, $patron_id ) );
>+                  && _ci_cardnumber_cmp( $item->{borrowernumber}, $patron->borrowernumber ) );
> 
>             $item->{borrowernumber}   = $patron_id;
>             $item->{due_date} = $circ->{due};
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25808: 106028 | 109188 | 114289 | 114898 | 115161 | 115436