Bugzilla – Attachment 11493 Details for
Bug 8524
Add barcode plugin that does not autofill
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8524 follow-up: fix broken test
Bug-8524-follow-up-fix-broken-test.patch (text/plain), 1.67 KB, created by
Kyle M Hall (khall)
on 2012-08-09 13:05:38 UTC
(
hide
)
Description:
Bug 8524 follow-up: fix broken test
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-08-09 13:05:38 UTC
Size:
1.67 KB
patch
obsolete
>From 0d7ec1cc71382a9f8a4f9178ae4b10ddf864e9e3 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Thu, 9 Aug 2012 07:45:05 -0400 >Subject: [PATCH] Bug 8524 follow-up: fix broken test > >The t/Barcodes_ValueBuilder.t test had the wrong number of tests >declared, and rather than checking that a variable was undefined I was >checking that it had a length of zero. Fixed both issues. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/Barcodes_ValueBuilder.t | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/Barcodes_ValueBuilder.t b/t/Barcodes_ValueBuilder.t >index c3d816e..0bbad8c 100644 >--- a/t/Barcodes_ValueBuilder.t >+++ b/t/Barcodes_ValueBuilder.t >@@ -2,7 +2,7 @@ > use strict; > use warnings; > use DBI; >-use Test::More tests => 15; >+use Test::More tests => 10; > use Test::MockModule; > > BEGIN { >@@ -40,7 +40,7 @@ my ($nextnum, $scr, $history); > > ($nextnum, $scr) = C4::Barcodes::ValueBuilder::incremental::get_barcode(\%args); > is($nextnum, 33333074344564, 'incremental barcode'); >-ok(length($scr) == 0, 'incremental javascript'); >+is($scr, undef, 'incremental javascript'); > > # This should run exactly one query so we can test > $history = $dbh->{mock_all_history}; >@@ -70,7 +70,7 @@ $dbh->{mock_add_resultset} = $annualdata; > $dbh->{mock_clear_history} = 1; > ($nextnum, $scr) = C4::Barcodes::ValueBuilder::annual::get_barcode(\%args); > is($nextnum, '2012-0035', 'annual barcode'); >-ok(length($scr) == 0, 'annual javascript'); >+is($scr, undef, 'annual javascript'); > > # This should run exactly one query so we can test > $history = $dbh->{mock_all_history}; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8524
:
11271
|
11343
|
11481
|
11484
|
11485
|
11491
|
11492
| 11493 |
11494
|
11495