Attachment 114931 Details for Bug 11299 – Bug 11299: Adjust call to check_cookie_auth

[patch] Bug 11299: Adjust call to check_cookie_auth

Bug-11299-Adjust-call-to-checkcookieauth.patch (text/plain), 1.28 KB, created by Nick Clemens (kidclamp) on 2021-01-07 16:06:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-01-07 16:06:08 UTC

Size: 1.28 KB

patch

obsolete

>From 9a4220f73d4cf0e5a22c69c6767c99f5819f3049 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 4 Jan 2021 15:46:56 +0100
>Subject: [PATCH] Bug 11299: Adjust call to check_cookie_auth
>
>Why were we using CGI::Cookie?
>---
> svc/cataloguing/automatic_linker.pl | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/svc/cataloguing/automatic_linker.pl b/svc/cataloguing/automatic_linker.pl
>index 5d7fd0f368..a04ccfb8c9 100755
>--- a/svc/cataloguing/automatic_linker.pl
>+++ b/svc/cataloguing/automatic_linker.pl
>@@ -19,9 +19,8 @@
> 
> use Modern::Perl;
> use CGI;
>-use CGI::Cookie;
> use JSON;
>-use C4::Auth;
>+use C4::Auth qw(check_cookie_auth);
> use C4::Biblio;
> use C4::Context;
> 
>@@ -29,10 +28,8 @@ my $input = CGI->new;
> print $input->header('application/json');
> 
> # Check the user's permissions
>-my %cookies = CGI::Cookie->fetch;
>-my $sessid = $cookies{'CGISESSID'}->value || $input->param('CGISESSID');
> my ( $auth_status, $auth_sessid ) =
>-  C4::Auth::check_cookie_auth( $sessid, { editauthorities => 1, editcatalogue => 1 } );
>+  C4::Auth::check_cookie_auth( $input->cookie('CGISESSID'), { editauthorities => 1, editcatalogue => 1 } );
> if ( $auth_status ne "ok" ) {
>     print to_json( { status => 'UNAUTHORIZED' } );
>     exit 0;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 11299: 23146 | 26715 | 33074 | 37912 | 37913 | 37972 | 38737 | 39477 | 39478 | 39479 | 40831 | 41229 | 45218 | 56440 | 56508 | 56509 | 58307 | 60998 | 63311 | 63312 | 63313 | 64075 | 67162 | 67708 | 67709 | 67710 | 67712 | 67713 | 67714 | 67824 | 67825 | 67826 | 67827 | 67828 | 67829 | 79385 | 79386 | 79387 | 79388 | 79389 | 79390 | 79391 | 79392 | 79393 | 79394 | 79395 | 79396 | 79397 | 79398 | 79399 | 79447 | 79448 | 79449 | 79450 | 79451 | 79452 | 79545 | 94818 | 95126 | 95152 | 98571 | 98572 | 99249 | 108091 | 108309 | 108310 | 108396 | 108552 | 108834 | 108835 | 109062 | 109063 | 109069 | 109181 | 110553 | 110554 | 110555 | 110556 | 110557 | 110568 | 110569 | 110570 | 110571 | 110572 | 111706 | 111707 | 111708 | 111709 | 111710 | 112125 | 112126 | 112127 | 112128 | 112129 | 112130 | 112131 | 112132 | 112133 | 112134 | 112135 | 113562 | 113563 | 113564 | 113565 | 113566 | 113567 | 113568 | 114803 | 114924 | 114925 | 114926 | 114927 | 114928 | 114929 | 114930 | 114931 | 114932