Bugzilla – Attachment 114962 Details for
Bug 27345
C4::Auth::get_template_and_user is missing some permissions for superlibrarian
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27345: Add missing global permissions for superlibrarian
Bug-27345-Add-missing-global-permissions-for-super.patch (text/plain), 2.30 KB, created by
Nick Clemens (kidclamp)
on 2021-01-08 13:40:28 UTC
(
hide
)
Description:
Bug 27345: Add missing global permissions for superlibrarian
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-01-08 13:40:28 UTC
Size:
2.30 KB
patch
obsolete
>From 74bc9d9da1c03fe0bd9cfb06af0ab663898daa80 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 5 Jan 2021 11:35:05 +0100 >Subject: [PATCH] Bug 27345: Add missing global permissions for superlibrarian > >When a superlibrarian is logged in, C4::Auth::get_template_and_user pass the CAN_user_$flag to the template, but some are missing: >suggestions, lists, cash_management > >So far they are not used in the template but it will avoid a developer to spend time on it if we fix it now. > >Test plan: >Compare with installer/data/mysql/mandatory/userflags.sql >Note that we don't need selfcheck > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Auth.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index d2d7c0f392..675344d4a5 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -319,17 +319,20 @@ sub get_template_and_user { > $template->param( CAN_user_editcatalogue => 1 ); > $template->param( CAN_user_updatecharges => 1 ); > $template->param( CAN_user_acquisition => 1 ); >+ $template->param( CAN_user_suggestions => 1 ); > $template->param( CAN_user_tools => 1 ); > $template->param( CAN_user_editauthorities => 1 ); > $template->param( CAN_user_serials => 1 ); > $template->param( CAN_user_reports => 1 ); > $template->param( CAN_user_staffaccess => 1 ); >- $template->param( CAN_user_plugins => 1 ); > $template->param( CAN_user_coursereserves => 1 ); >+ $template->param( CAN_user_plugins => 1 ); >+ $template->param( CAN_user_lists => 1 ); > $template->param( CAN_user_clubs => 1 ); > $template->param( CAN_user_ill => 1 ); > $template->param( CAN_user_stockrotation => 1 ); >- $template->param( CAN_user_problem_reports => 1 ); >+ $template->param( CAN_user_cash_management => 1 ); >+ $template->param( CAN_user_problem_reports => 1 ); > > foreach my $module ( keys %$all_perms ) { > foreach my $subperm ( keys %{ $all_perms->{$module} } ) { >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=114962">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27345
:
114873
|
114901
| 114962