Attachment 115016 Details for Bug 26851 – Bug 26851: Don't generate a notice to library if no content

[patch] Bug 26851: Don't generate a notice to library if no content

Bug-26851-Dont-generate-a-notice-to-library-if-no-.patch (text/plain), 1.61 KB, created by Martin Renvoize (ashimema) on 2021-01-11 12:29:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-01-11 12:29:30 UTC

Size: 1.61 KB

patch

obsolete

>From 3670f3d83608467f2a373b9974a61f20da374917 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 28 Oct 2020 19:00:28 +0000
>Subject: [PATCH] Bug 26851: Don't generate a notice to library if no content
>
>To test:
> 1 - Check out an over due to a patron
> 2 - Set overdue triggers to a trigger less than number of days overdue
> 3 - Make sure the patron has no email
> 4 - Set content of ODUE notice to:
>    [%# Comment will not print %]
> 5 - perl misc/cronjobs/overdue_notices.pl
> 6 - Check the message queue
> 7 - There is a notice sent to the library:
>    "These messages were not sent directly to the patrons."
>    With no messages
> 8 - Apply patch
> 9 - Repeat
>10 - No new message generated
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> misc/cronjobs/overdue_notices.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index 1a7d59d6a6..7b50f254c6 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -731,7 +731,7 @@ END_SQL
>                             message_transport_type => $letter_exists ? $effective_mtt : $mtt,
>                         }
>                     );
>-                    unless ($letter) {
>+                    unless ($letter && $letter->{content}) {
>                         $verbose and warn qq|Message '$overdue_rules->{"letter$i"}' content not found|;
>                         # this transport doesn't have a configured notice, so try another
>                         next;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26851: 112650 | 114371 | 115016