Bugzilla – Attachment 115017 Details for
Bug 27149
Z3950Responder removes itemnumber when adding item statuses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27149: Unit tests
Bug-27149-Unit-tests.patch (text/plain), 2.27 KB, created by
Martin Renvoize (ashimema)
on 2021-01-11 12:33:08 UTC
(
hide
)
Description:
Bug 27149: Unit tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-01-11 12:33:08 UTC
Size:
2.27 KB
patch
obsolete
>From 660b315c311909c66dd24de8ec1f0dba07539bcb Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 3 Dec 2020 17:03:40 +0000 >Subject: [PATCH] Bug 27149: Unit tests > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Z3950Responder/Session.t | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/Z3950Responder/Session.t b/t/db_dependent/Koha/Z3950Responder/Session.t >index a3735f32e0..6493481ab7 100755 >--- a/t/db_dependent/Koha/Z3950Responder/Session.t >+++ b/t/db_dependent/Koha/Z3950Responder/Session.t >@@ -17,7 +17,7 @@ $schema->storage->txn_begin; > > subtest 'add_item_status' => sub { > >- plan tests => 2; >+ plan tests => 3; > > ## FIRST ITEM HAS ALL THE STATUSES ## > my $item_1 = $builder->build_sample_item( >@@ -29,8 +29,9 @@ subtest 'add_item_status' => sub { > withdrawn => 1, > } > ); >+ my ( $itemtag, $itemsubfield ) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" ); > my $item_marc_1 = C4::Items::GetMarcItem( $item_1->biblionumber, $item_1->itemnumber ); >- my $item_field_1 = scalar $item_marc_1->field('952'); >+ my $item_field_1 = scalar $item_marc_1->field($itemtag); > $builder->build({ source => 'Reserve', value=> { itemnumber => $item_1->itemnumber } }); > $builder->build({ source => 'Branchtransfer', value=> { itemnumber => $item_1->itemnumber, datearrived => undef } }); > ## END FIRST ITEM ## >@@ -38,7 +39,7 @@ subtest 'add_item_status' => sub { > ## SECOND ITEM HAS NO STATUSES ## > my $item_2 = $builder->build_sample_item; > my $item_marc_2 = C4::Items::GetMarcItem( $item_2->biblionumber, $item_2->itemnumber ); >- my $item_field_2 = scalar $item_marc_2->field('952'); >+ my $item_field_2 = scalar $item_marc_2->field($itemtag); > ## END SECOND ITEM ## > > # Create the responder >@@ -52,6 +53,8 @@ subtest 'add_item_status' => sub { > $args->{HANDLE}->add_item_status($item_field_2); > is($item_field_2->subfield('k'),'Available',"Available status added as expected"); > >+ is($item_field_2->subfield( $itemsubfield ), $item_2->itemnumber, "Itemnumber not removed when status added"); >+ > }; > > $schema->storage->txn_rollback; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27149
:
114155
|
114156
|
114230
|
114231
|
114320
|
114321
| 115017 |
115018
|
115063