Attachment 115019 Details for Bug 26698 – Bug 26698: Use is_at_destination to determine if hold is at destination

[patch] Bug 26698: Use is_at_destination to determine if hold is at destination

Bug-26698-Use-isatdestination-to-determine-if-hold.patch (text/plain), 2.18 KB, created by Martin Renvoize (ashimema) on 2021-01-11 12:37:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-01-11 12:37:55 UTC

Size: 2.18 KB

patch

obsolete

>From b0d026e986d316b65c6dbd14a731f4ff71d16334 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 15 Oct 2020 19:24:24 +0000
>Subject: [PATCH] Bug 26698: Use is_at_destination to determine if hold is at
> destination
>
>This copies code from bug 12556 and uses a Koha::Hold method rather than
>code in script
>
>TO test:
>1 - Place a hold for item from library B for delivery at library A
>2 - Check the item in at library B, confirm and transfer
>3 - Check item in at Library A but ignore the hold
>4 - View the Holds tab of the details page:
>    http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6
>5 - Priority = "In transit"  Pickup Library = "Item waiting at"
>6 - Apply patch
>7 - Restart all the thigns
>8 - Reload the page
>9 - Priority="In transit" and Pickup library="Item being transferred"
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> reserve/request.pl | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 0ae6a3f317..8d4192883c 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -662,17 +662,7 @@ foreach my $biblionumber (@biblionumbers) {
>             $reserve{'wbrcode'}       = $res->branchcode();
>             $reserve{'itemnumber'}    = $res->itemnumber();
>             $reserve{'wbrname'}       = $res->branch()->branchname();
>-
>-            if ( $reserve{'holdingbranch'} eq $reserve{'wbrcode'} ) {
>-
>-                # Just because the holdingbranch matches the reserve branch doesn't mean the item
>-                # has arrived at the destination, check for an open transfer for the item as well
>-                my ( $transfertwhen, $transfertfrom, $transferto ) =
>-                  C4::Circulation::GetTransfers( $res->itemnumber() );
>-                if ( not $transferto or $transferto ne $res->branchcode() ) {
>-                    $reserve{'atdestination'} = 1;
>-                }
>-            }
>+            $reserve{'atdestination'} = $res->is_at_destination();
> 
>             # set found to 1 if reserve is waiting for patron pickup
>             $reserve{'found'}     = $res->is_found();
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26698: 111789 | 114486 | 115019