Bugzilla – Attachment 115023 Details for
Bug 21301
Restriction of the informations given by GetRecords ILS-DI service
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service
Bug-21301-Remove-patron-informations-in-reserves-f.patch (text/plain), 1.72 KB, created by
Nick Clemens (kidclamp)
on 2021-01-11 13:24:43 UTC
(
hide
)
Description:
Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-01-11 13:24:43 UTC
Size:
1.72 KB
patch
obsolete
>From 4f4bda3dcf3eec3acbf1623f47e7d07efd162c00 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 3 Oct 2019 15:43:56 +0200 >Subject: [PATCH] Bug 21301: Remove patron informations in reserves for > GetRecords ILS-DI service > >Actually, the GetRecords service gives many information : >borrowernumber (reserves field) > >The issue data should not be sent by these service, its a privacy problem. > >Test plan : >1) Enable ILS-DI webservice >2) Place hold on an item >3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} >4) Check the reserves tag content > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/ILSDI/Services.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index 30a03bceb2..3a1d0844ee 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -227,7 +227,6 @@ sub GetRecords { > > # Get most of the needed data > my $biblioitemnumber = $biblioitem->{'biblioitemnumber'}; >- my $holds = $biblio->current_holds->unblessed; > my $checkouts = Koha::Checkouts->search( > { biblionumber => $biblionumber }, > { >@@ -279,6 +278,12 @@ sub GetRecords { > push @{ $biblioitem->{items}->{item} }, \%item; > } > >+ # Holds >+ my $holds = $biblio->current_holds->unblessed; >+ foreach my $hold (@$holds) { >+ delete $hold->{'borrowernumber'}; >+ } >+ > # Hashref building... > $biblioitem->{'reserves'}->{'reserve'} = $holds; > $biblioitem->{'issues'}->{'issue'} = $checkouts; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21301
:
93495
|
93603
|
95158
|
95159
|
95178
|
101818
|
109646
|
113061
|
113062
|
113063
|
113064
|
113065
|
113068
|
113069
|
113070
|
113071
|
113072
|
115022
| 115023 |
115024
|
115025
|
115026