Attachment 11505 Details for Bug 5327 – [PASSED-QA]Added and tested a mock-db tested a couple of features

[patch] [PASSED-QA]Added and tested a mock-db tested a couple of features

Added-and-tested-a-mock-db-tested-a-couple-of-feat.patch (text/plain), 2.84 KB, created by Jonathan Druart on 2012-08-09 14:33:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2012-08-09 14:33:39 UTC

Size: 2.84 KB

patch

obsolete

>From 17e01339a2f56d3c240d4f2b05215cc3034b12db Mon Sep 17 00:00:00 2001
>From: Bart Jorgensen <bart.tj@gmail.com>
>Date: Wed, 8 Aug 2012 21:23:55 +1200
>Subject: [PATCH] Added and tested a mock-db tested a couple of features
>
>http://bugs.koha-community.org/show_bug.cgi?id=5327
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>All tests pass!
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> t/Members_AttributeTypes.t |   63 ++++++++++++++++++++++++++++++++++++++++---
> 1 files changed, 58 insertions(+), 5 deletions(-)
>
>diff --git a/t/Members_AttributeTypes.t b/t/Members_AttributeTypes.t
>index 9dfc6c3..5aba165 100755
>--- a/t/Members_AttributeTypes.t
>+++ b/t/Members_AttributeTypes.t
>@@ -1,14 +1,67 @@
> #!/usr/bin/perl
> #
>-# This Koha test module is a stub!  
>-# Add more tests here!!!
>+# Tests 'fetch', 'fake db data', and 'checks for existant attributes'
> 
> use strict;
> use warnings;
>-
>-use Test::More tests => 1;
>+use Test::MockModule;
>+use Test::More tests => 9;
> 
> BEGIN {
>-        use_ok('C4::Members::AttributeTypes');
>+    use_ok('C4::Members::AttributeTypes');
> }
> 
>+my $module = new Test::MockModule('C4::Context');
>+$module->mock(
>+    '_new_dbh',
>+    sub {
>+        my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
>+          || die "Cannot create handle: $DBI::errstr\n";
>+        return $dbh;
>+    }
>+);
>+my $members_attributetypes = [
>+    [
>+        'code',             'description',
>+        'repeatable',       'unique_id',
>+        'opac_display',     'password_allowed',
>+        'staff_searchable', 'authorised_value_category',
>+        'display_checkout', 'catagory_code',
>+        'class'
>+    ],
>+    [ 'one', 'ISBN', '1', '1', '1', '1', '1', 'red',  '1', 'orange', 'green' ],
>+    [ 'two', 'ISSN', '0', '0', '0', '0', '0', 'blue', '0', 'yellow', 'silver' ]
>+];
>+
>+my $dbh = C4::Context->dbh();
>+
>+$dbh->{mock_add_resultset} = $members_attributetypes;
>+
>+my @members_attributetypes = C4::Members::AttributeTypes::GetAttributeTypes();
>+
>+is( $members_attributetypes[0]->{'code'}, 'one', 'First code value is one' );
>+
>+is( $members_attributetypes[1]->{'code'}, 'two', 'Second code value is two' );
>+
>+is( $members_attributetypes[0]->{'class'},
>+    'green', 'First class value is green' );
>+
>+is( $members_attributetypes[1]->{'class'},
>+    'silver', 'Second class value is silver' );
>+
>+$dbh->{mock_add_resultset} = $members_attributetypes;
>+
>+ok( C4::Members::AttributeTypes::AttributeTypeExists('one'),
>+    'checking an attribute type exists' );
>+
>+ok(
>+    !C4::Members::AttributeTypes::AttributeTypeExists('three'),
>+    "checking a attribute that isn't in the code doesn't exist"
>+);
>+
>+$dbh->{mock_add_resultset} = $members_attributetypes;
>+
>+ok( C4::Members::AttributeTypes->fetch('ISBN'), "testing fetch feature" );
>+
>+ok( !C4::Members::AttributeTypes->fetch('FAKE'),
>+    "testing fetch feature doesn't work if value not in database" );
>-- 
>1.7.7.3

Actions: View | Diff | Splinter Review

Attachments on bug 5327: 2716 | 2726 | 5485 | 6236 | 6237 | 6373 | 6560 | 6561 | 6562 | 6563 | 6613 | 6614 | 6616 | 6620 | 6621 | 6622 | 6643 | 6650 | 6655 | 6679 | 6681 | 6682 | 6683 | 6726 | 6727 | 6728 | 6729 | 6730 | 6731 | 6732 | 6795 | 6799 | 6805 | 6819 | 6826 | 6827 | 6828 | 6834 | 7179 | 7180 | 7181 | 7182 | 7183 | 7184 | 7185 | 7186 | 7187 | 7188 | 7189 | 7190 | 7191 | 7192 | 7194 | 7195 | 7203 | 7206 | 7208 | 7209 | 7220 | 7221 | 7222 | 7223 | 7224 | 7225 | 7226 | 7227 | 7228 | 7229 | 7230 | 7231 | 7232 | 7233 | 7234 | 7235 | 7236 | 7237 | 7238 | 7239 | 7240 | 7241 | 7242 | 7400 | 7402 | 7403 | 7405 | 7573 | 7592 | 7593 | 7594 | 9897 | 10234 | 10616 | 10656 | 10659 | 10660 | 10661 | 10680 | 11141 | 11186 | 11212 | 11213 | 11278 | 11279 | 11280 | 11281 | 11339 | 11340 | 11341 | 11440 | 11467 | 11469 | 11470 | 11471 | 11472 | 11473 | 11500 | 11503 | 11505 | 11506 | 11633 | 11762 | 11763 | 11764 | 11765 | 11846 | 11985 | 11993 | 12002 | 12003