Attachment 115064 Details for Bug 14004 – Bug 14004: Add ability to temporarily disable JS/CSS sysprefs

[patch] Bug 14004: Add ability to temporarily disable JS/CSS sysprefs

Bug-14004-Add-ability-to-temporarily-disable-JSCSS.patch (text/plain), 2.03 KB, created by Fridolin Somers on 2021-01-12 10:52:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2021-01-12 10:52:23 UTC

Size: 2.03 KB

patch

obsolete

>From af669880d294706f765b0da0497b998f8c222047 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 12 Jan 2021 11:15:25 +0100
>Subject: [PATCH] Bug 14004: Add ability to temporarily disable JS/CSS sysprefs
>
>It would be *super* handy if intranetuserjs and/or opacuserjs could be temporarily disabled via a check-box or syspref.
>Right now, debugging issues in intranetuserjs usuaally starts with copying the contents into a text file, blanking the syspref and re-testing.
>
>This patch adds this feature by setting syspref via ENV OVERRIDE_SYSPREF
>like override via Apache config.
>Note that this only works for
>
>Implemented only for preferences :
>OPACUserCSS OPACUserJS IntranetUserCSS IntranetUserJS
>=> replaced with ' '
>intranetcolorstylesheet intranetstylesheet
>=> replaced with 0
>
>Test plan :
>1) Set some CSS in IntranetUserCSS like : #breadcrumbs{color:red}
>2) Go to staff interface home page like : /cgi-bin/koha/mainpage.pl
>3) See CSS impact is visible
>4) Edit URL : /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_IntranetUserCSS=1
>5) See CSS impact is not visible
>6) Check with the other preferences
>---
> C4/Auth.pm | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index 675344d4a5..f0b579565b 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -440,6 +440,15 @@ sub get_template_and_user {
>         }
>     }
> 
>+    # Sysprefs disabled via URL param
>+    # Note that value must be defined in order to override via ENV
>+    foreach my $syspref ( qw( OPACUserCSS OPACUserJS IntranetUserCSS IntranetUserJS ) ) {
>+        $ENV{"OVERRIDE_SYSPREF_$syspref"} = q{ } if $in->{'query'}->param("DISABLE_SYSPREF_$syspref");
>+    }
>+    foreach my $syspref ( qw( intranetcolorstylesheet intranetstylesheet ) ) {
>+        $ENV{"OVERRIDE_SYSPREF_$syspref"} = 0 if $in->{'query'}->param("DISABLE_SYSPREF_$syspref");
>+    }
>+
>     # Anonymous opac search history
>     # If opac search history is enabled and at least one search has already been performed
>     if ( C4::Context->preference('EnableOpacSearchHistory') ) {
>-- 
>2.30.0

Actions: View | Diff | Splinter Review

Attachments on bug 14004: 115064 | 115120 | 115567 | 115583 | 115584 | 115589 | 115590 | 115871 | 115874 | 115876 | 115883