Bugzilla – Attachment 115075 Details for
Bug 27308
Advanced editor should skip blank lines when inserting new fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27308: (QA follow-up) Remove commented line
Bug-27308-QA-follow-up-Remove-commented-line.patch (text/plain), 1.22 KB, created by
Martin Renvoize (ashimema)
on 2021-01-12 11:50:47 UTC
(
hide
)
Description:
Bug 27308: (QA follow-up) Remove commented line
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-01-12 11:50:47 UTC
Size:
1.22 KB
patch
obsolete
>From 3ede0787eb44fbbd3739422d7203cb117e501ffb Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 12 Jan 2021 11:49:46 +0000 >Subject: [PATCH] Bug 27308: (QA follow-up) Remove commented line > >I don't think we need to keep the original line as a comment.. this >patch simply cleans it up. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js >index bd3d38a212..6d90176e0a 100644 >--- a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js >+++ b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js >@@ -812,7 +812,6 @@ define( [ 'marc-record', 'koha-backend', 'preferences', 'text-marc', 'widget' ], > createFieldOrdered: function( tag ) { > var line, contents; > >- //for ( line = 0; (contents = this.cm.getLine(line)); line++ ) { > for ( line = 0; line <= this.cm.lastLine(); line++ ) { > contents = this.cm.getLine(line); > if ( contents && contents.substr(0, 3) > tag ) break; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27308
:
114698
|
114762
|
115074
|
115075
|
115093