Attachment 115131 Details for Bug 24254 – Bug 24254: Fix ISE

[patch] Bug 24254: Fix ISE

Bug-24254-Fix-ISE.patch (text/plain), 1.39 KB, created by Jonathan Druart on 2021-01-14 09:45:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-01-14 09:45:22 UTC

Size: 1.39 KB

patch

obsolete

>From 486d97296c026ad61a9c1d4ae3a68984abea2cd8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 14 Jan 2021 10:42:53 +0100
>Subject: [PATCH] Bug 24254: Fix ISE
>
>The method Koha::Items->itemnumber is not covered by tests!
>
>Trace begun at /kohadevbox/koha/Koha/Objects.pm line 592
>Koha::Objects::AUTOLOAD('Koha::Items=HASH(0x55981fd94790)') called at /kohadevbox/koha/opac/opac-reserve.pl line 465
>---
> opac/opac-reserve.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index eb8c2660a8..d6e6745c6b 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -462,7 +462,7 @@ foreach my $biblioNum (@biblionumbers) {
>     my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode });
>     my $notforloan_label_of = { map { $_->authorised_value => $_->opac_description } @notforloan_avs };
> 
>-    my $visible_items = { map { $_->itemnumber => 1 } $biblio->items->filter_by_visible_in_opac( { patron => $patron } ) };
>+    my $visible_items = { map { $_->itemnumber => 1 } $biblio->items->filter_by_visible_in_opac( { patron => $patron } )->as_list };
> 
>     # Only keep the items that are visible in the opac (i.e. those in %visible_items)
>     # FIXME: We should get rid of itemInfos altogether and use $visible_items
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24254: 96373 | 114159 | 114160 | 114206 | 114207 | 114278 | 114279 | 114539 | 114540 | 114548 | 114549 | 114550 | 114551 | 114574 | 114594 | 114595 | 114596 | 114597 | 114598 | 114599 | 114664 | 114665 | 114666 | 114667 | 114668 | 115131 | 115132 | 115147 | 115148 | 115149 | 115150 | 115151 | 115152 | 115153 | 116070 | 116071 | 116072 | 116073 | 116074 | 116075