Attachment 115175 Details for Bug 26351 – Bug 26351: (QA follow-up) Remove unused method barcode_transform

[patch] Bug 26351: (QA follow-up) Remove unused method barcode_transform

Bug-26351-QA-follow-up-Remove-unused-method-barcod.patch (text/plain), 1.98 KB, created by Kyle M Hall (khall) on 2021-01-14 16:00:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-01-14 16:00:02 UTC

Size: 1.98 KB

patch

obsolete

>From a36f4a0be5e2b88a7271e32cc93d7a1751515582 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 12 Nov 2020 12:12:35 -0500
>Subject: [PATCH] Bug 26351: (QA follow-up) Remove unused method
> barcode_transform
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Koha/Plugins/Plugins.t | 3 +--
> t/lib/Koha/Plugin/Test.pm             | 5 -----
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Plugins/Plugins.t b/t/db_dependent/Koha/Plugins/Plugins.t
>index bf5c33c524..c15153cef8 100755
>--- a/t/db_dependent/Koha/Plugins/Plugins.t
>+++ b/t/db_dependent/Koha/Plugins/Plugins.t
>@@ -25,7 +25,7 @@ use File::Temp qw( tempdir tempfile );
> use FindBin qw($Bin);
> use Module::Load::Conditional qw(can_load);
> use Test::MockModule;
>-use Test::More tests => 55;
>+use Test::More tests => 54;
> 
> use C4::Context;
> use Koha::Database;
>@@ -182,7 +182,6 @@ ok( $plugin->can('opac_js'), 'Test plugin can opac_js' );
> ok( $plugin->can('intranet_head'), 'Test plugin can intranet_head' );
> ok( $plugin->can('intranet_js'), 'Test plugin can intranet_js' );
> ok( $plugin->can('barcode_transform'), 'Test plugin can barcode_transform' );
>-ok( $plugin->can('barcode_generate'), 'Test plugin can barcode_generate' );
> ok( $plugin->can('configure'), 'Test plugin can configure' );
> ok( $plugin->can('install'), 'Test plugin can install' );
> ok( $plugin->can('upgrade'), 'Test plugin can upgrade' );
>diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm
>index 18767dc295..552e38788a 100644
>--- a/t/lib/Koha/Plugin/Test.pm
>+++ b/t/lib/Koha/Plugin/Test.pm
>@@ -98,11 +98,6 @@ sub barcode_transform {
>     Koha::Exceptions::Exception->throw("barcode_transform called with parameters: $type, $barcode");
> }
> 
>-sub barcode_generate {
>-    my ( $self, $type, $object ) = @_;
>-    return "Koha::Plugin::Test::barcode_generate";
>-}
>-
> sub configure {
>     my ( $self, $args ) = @_;
>     return "Koha::Plugin::Test::configure";
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26351: 109532 | 109548 | 109671 | 110844 | 110846 | 111575 | 111577 | 111578 | 111579 | 111862 | 111863 | 111894 | 111916 | 111917 | 111918 | 111919 | 111920 | 111921 | 111922 | 113571 | 113572 | 113573 | 113574 | 113575 | 113576 | 113577 | 113578 | 115172 | 115173 | 115174 | 115175 | 115176 | 115177 | 115178 | 115179 | 115180 | 118649 | 118650 | 118651 | 118652 | 118653 | 118654 | 118655 | 118656 | 118657 | 118658 | 118681 | 118682 | 118683 | 118684 | 118685 | 118686 | 118687 | 118688 | 118689 | 118690 | 122433 | 122434 | 122435 | 122436 | 122437 | 122438 | 122439 | 122440 | 122441 | 122442 | 124258 | 124259 | 124260 | 124261 | 124262 | 124263 | 124264 | 124265 | 124266 | 124313 | 125447 | 125763 | 125764 | 125765