Attachment 11518 Details for Bug 8573 – Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction

[patch] Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction

Bug-8573---Translation-difficult-in-picture-upload.patch (text/plain), 5.02 KB, created by Marc Véron on 2012-08-10 04:23:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2012-08-10 04:23:18 UTC

Size: 5.02 KB

patch

obsolete

>From 35a1c341f12c8434bcfbadd450c2c2d8fe508f3d Mon Sep 17 00:00:00 2001
>From: Marc Veron <veron@veron.ch>
>Date: Fri, 10 Aug 2012 06:20:55 +0200
>Subject: [PATCH] Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction
>Content-Type: text/plain; charset="utf-8"
>
>Text could not be correctly translated due to poor parsing of nested sentences in Pootle.
>
>*Sentences de-nested to have whole sentence in each if /elsif branch
>*Cleaned up <li></li> handling: moved closing </li> outside the for each loop to prevent orphaned closing </li>s.
>*Changed indentation for better readibility
>*Changed WARNING to ERROR because it is an *Error* during upload.
>*Wording simplified (for translation).
>*In one case added hint to refer to online help (size).
>
>This way text should be easier to be translated in Pootle.
>---
> .../prog/en/modules/tools/picture-upload.tt | 33 +++++++++++---------
> 1 files changed, 18 insertions(+), 15 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt
>index 3520048..51a78c5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt
>@@ -43,26 +43,29 @@
> <li>[% TOTAL %] directories scanned.</li>
> <li>[% HANDLED %] directories processed.</li>
> </ul>
>+
> [% FOREACH COUNT IN COUNTS %]
>-	 <ul class="data">
>+ <ul class="data">
> [% IF ( COUNT.TCOUNTS ) %]<li>[% COUNT.TCOUNTS %] image(s) moved into the database:</li>[% END %]
>- [% FOREACH filename IN COUNT.filenames %]
>- <li>[% filename.source %] - Cardnumber: [% filename.cardnumber %]
>- [% IF ( filename.filerrors ) %] WARNING: This image not imported because 
>+ [% FOREACH filename IN COUNT.filenames %]
>+ <li>[% filename.source %] - Cardnumber: [% filename.cardnumber %]
>+ [% IF ( filename.filerrors ) %]
> [% FOREACH filerror IN filename.filerrors %]
>- [% IF ( filerror.DBERR ) %]the database returned an error. Please refer to the error log for more details.</li>
>- [% ELSIF ( filerror.IMGEXISTS ) %]this patron does not exist in the database.</li>
>- [% ELSIF ( filerror.MIMERR ) %]the image format is unrecognized.</li>
>- [% ELSIF ( filerror.CORERR ) %]the image file is corrupted.</li>
>- [% ELSIF ( filerror.OPNERR ) %]Koha was unable to open the image for reading.</li>
>- [% ELSIF ( filerror.OVRSIZ ) %]the image file is too big.</li>
>- [% ELSIF ( filerror.CRDFIL ) %]the [% filerror.CRDFIL %] is missing.</li>
>- [% ELSE %]of an unknown error. Please refer to the error log for more details.</li>[% END %]
>- [% END %]
>- [% ELSE %] imported successfully.</li>
>+ [% IF ( filerror.DBERR ) %] ERROR: Image not imported because the database returned an error. Please refer to the error log for more details.
>+ [% ELSIF ( filerror.IMGEXISTS ) %] ERROR: Image not imported because this patron does not exist in the database.
>+ [% ELSIF ( filerror.MIMERR ) %] ERROR: Image not imported because the image format is unrecognized.
>+ [% ELSIF ( filerror.CORERR ) %] ERROR: Image not imported because the image file is corrupted.
>+ [% ELSIF ( filerror.OPNERR ) %] ERROR: Image not imported because Koha was unable to open the image for reading.
>+ [% ELSIF ( filerror.OVRSIZ ) %] ERROR: Image not imported because the image file is too big (see online help for maximum size).
>+ [% ELSIF ( filerror.CRDFIL ) %] ERROR: Image not imported ([% filerror.CRDFIL %] missing).
>+ [% ELSE %] ERROR: Image not imported because of an unknown error. Please refer to the error log for more details.
>+ [% END %]
> [% END %]
>+ [% ELSE %] imported successfully.
>+ [% END %]
>+ </li>
> [% END %]
>- </ul>
>+ </ul>
> [% END %]
> 
> 				</div>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8573: 11375 | 11517 | 11518 | 11523