Attachment 115192 Details for Bug 24272 – Bug 24272: (follow-up) Test defined not true

[patch] Bug 24272: (follow-up) Test defined not true

Bug-24272-follow-up-Test-defined-not-true.patch (text/plain), 1017 bytes, created by Nick Clemens (kidclamp) on 2021-01-15 11:01:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-01-15 11:01:06 UTC

Size: 1017 bytes

patch

obsolete

>From 496402fcd54a6b67bdbd8e87cfa5193d7f88da74 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 15 Jan 2021 11:00:39 +0000
>Subject: [PATCH] Bug 24272: (follow-up) Test defined not true
>
>---
> misc/maintenance/check_syspref_cache.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/maintenance/check_syspref_cache.pl b/misc/maintenance/check_syspref_cache.pl
>index 809ecaae05..ac60081389 100755
>--- a/misc/maintenance/check_syspref_cache.pl
>+++ b/misc/maintenance/check_syspref_cache.pl
>@@ -43,6 +43,6 @@ my $prefs = Koha::Config::SysPrefs->search();
> while  (my $pref = $prefs->next) {
>     my $var = lc $pref->variable;
>     my $cached_var = $syspref_cache->get_from_cache("syspref_$var");
>-    next unless $cached_var;
>+    next unless defined $cached_var; #If not defined in cache we will fetch from DB so this case is OK
>     print "$var: value in cache is $cached_var and value in db is ".$pref->value,"\n" unless $cached_var eq $pref->value;
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24272: 96467 | 113135 | 113193 | 115029 | 115192 | 115412 | 115413