Bugzilla – Attachment 115205 Details for
Bug 25540
Biblio.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22284: (QA follow-up) Fix test failures
Bug-22284-QA-follow-up-Fix-test-failures.patch (text/plain), 1.09 KB, created by
Nick Clemens (kidclamp)
on 2021-01-15 14:13:41 UTC
(
hide
)
Description:
Bug 22284: (QA follow-up) Fix test failures
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-01-15 14:13:41 UTC
Size:
1.09 KB
patch
obsolete
>From 3958935312090bdaba656448e78e0fe562a81a93 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 15 Jan 2021 14:00:55 +0000 >Subject: [PATCH] Bug 22284: (QA follow-up) Fix test failures > >Only libraries that are a pickup location will be returned as a pickup location > >To test: >prove -v t/db_dependent/Koha/Biblio.t >it succeeds (maybe) >add a library that is not a pickup_location >prove the test >it fails >apply the patch >prove! >it passes! > >https://bugs.koha-community.org/show_bug.cgi?id=25540 >--- > t/db_dependent/Koha/Biblio.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t >index 485b31a14e..cbcf3b5827 100644 >--- a/t/db_dependent/Koha/Biblio.t >+++ b/t/db_dependent/Koha/Biblio.t >@@ -189,7 +189,7 @@ subtest 'pickup_locations' => sub { > > $schema->storage->txn_begin; > >- my $nb_libraries = Koha::Libraries->count; >+ my $nb_libraries = Koha::Libraries->search({ pickup_location => 1 })->count; > Koha::CirculationRules->search->delete; > Koha::CirculationRules->set_rules( > { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25540
:
105093
|
105094
|
105266
|
105290
|
105291
|
105292
|
105296
|
105297
|
115204
| 115205