Bugzilla – Attachment 115222 Details for
Bug 27047
Purchase suggestions search filter is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27047: Fix suggestions filtering at the OPAC
Bug-27047-Fix-suggestions-filtering-at-the-OPAC.patch (text/plain), 2.33 KB, created by
Katrin Fischer
on 2021-01-17 15:48:42 UTC
(
hide
)
Description:
Bug 27047: Fix suggestions filtering at the OPAC
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-01-17 15:48:42 UTC
Size:
2.33 KB
patch
obsolete
>From aa8c0add47cac25a8625507cb0bdfa37596d7c7c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 15 Jan 2021 11:16:26 +0100 >Subject: [PATCH] Bug 27047: Fix suggestions filtering at the OPAC > >There is a "Search" input box that appears to be broken for... ever? > >This patch replaces it with the DataTables filtering. > >Test plan: >Create some suggestions, go to your suggestion list at the OPAC >Confirm that the filtering now works correctly > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index c5d8ef650d..929d7094a5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -288,10 +288,6 @@ > [% SET can_delete_suggestion = 0 %] > <form action="/cgi-bin/koha/opac-suggestions.pl" class="form-inline" id="search_suggestions_form" method="get"> > <div class="form-row"> >- <div class="col-auto my-1"> >- <label class="sr-only" for="title">Search for:</label> >- <input class="form-control form-control-sm" type="text" name="title" placeholder="Search suggestions" id="title" value="[% title | html %]" /> >- </div> > [% IF Koha.Preference( 'OPACViewOthersSuggestions' ) == 1 %] > [% IF loggedinusername %] > <div class="col-auto my-1"> >@@ -484,6 +480,7 @@ > $(function() { > $("#suggestt").dataTable($.extend(true, {}, dataTablesDefaults, { > "order": [[ 1, "asc" ]], >+ "dom": '<"top"<"table_entries"><"table_controls"f>>t', > "autoWidth": false, > "columnDefs": [ > [% IF ( loggedinusername ) %]{ "targets": [ 0 ], "sortable": false, "searchable": false }[% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27047
:
115189
|
115211
| 115222