Bugzilla – Attachment 115223 Details for
Bug 27420
A mistake in bug 5161 leads to some patron attributes appearing without a fieldset
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27420: Use object accessor for $attr_type->class()
Bug-27420-Use-object-accessor-for-attrtype-class.patch (text/plain), 1.61 KB, created by
Katrin Fischer
on 2021-01-17 16:00:58 UTC
(
hide
)
Description:
Bug 27420: Use object accessor for $attr_type->class()
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-01-17 16:00:58 UTC
Size:
1.61 KB
patch
obsolete
>From 5c5b70083f0984137d447373c01bea84b041377d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 13 Jan 2021 11:22:53 +0000 >Subject: [PATCH] Bug 27420: Use object accessor for $attr_type->class() > >We introduced a bug in the patron attribute forms with bug 5161. > >Test plan >1/ Create two PA_CLASS authorized values >2/ Create two corresponding patron attribute types referencing the above >classes. >3/ Edit a patron, both attributes should appear within their own >fieldsets at the bottom of the member entry form. >4/ Set a value for the first of the two patron attributes and save >5/ Edit the patron again, note that the first attribute no longer >resides within it's own fieldset >6/ Apply the patch >7/ Edit the patron again, note that the first attribute now resides >inside it's own fieldset again >8/ Signoff > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 221026acb9..3fe2e97aa6 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -944,7 +944,7 @@ sub patron_attributes_form { > $i++; > undef $newentry->{value} if ($attr_type->unique_id() && $op eq 'duplicate'); > $newentry->{form_id} = "patron_attr_$i"; >- push @{$items_by_class{$attr_type->{class}}}, $newentry; >+ push @{$items_by_class{$attr_type->class()}}, $newentry; > } > } else { > $i++; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27420
:
115110
|
115114
| 115223