Attachment 115319 Details for Bug 27011 – Bug 27011: Remove unused $name variable

[patch] Bug 27011: Remove unused $name variable

Bug-27011-Remove-unused-name-variable.patch (text/plain), 2.02 KB, created by Andrew Fuerste-Henry on 2021-01-19 13:34:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Fuerste-Henry

Created: 2021-01-19 13:34:24 UTC

Size: 2.02 KB

patch

obsolete

>From 8017de1b094025f32b091652152e37902fd5980c Mon Sep 17 00:00:00 2001
>From: Amy King <amyking386@gmail.com>
>Date: Tue, 19 Jan 2021 03:27:27 +0000
>Subject: [PATCH] Bug 27011: Remove unused $name variable
>
>The variable is no longer used in the template, it has been removed by:
>
>  commit 76eb3a0549efe4c1f1557071a6cb4b33d4bd3e4d
>  Bug 18789: (follow-up) Pass a Koha::Patron object from returns.pl
>
>-            <td>[% name %]</td>
>+            <td>[% INCLUDE 'patron-title.inc' patron=patron %]</td>
>
>We can simply remove the $name variable from the controller script.
>
>Test Plan:
>1. Check out a book
>2. Check in a book
>3. Note what happens
>4. Apply patch
>5. Repeat step 1-2
>6. Note that it doesn't break and everything still works
>
>JD Amended patch: fix commit message
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>---
> circ/returns.pl | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 116ac3c15e..4e9662024c 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -162,13 +162,11 @@ if ( $query->param('reserve_id') ) {
>     my ( $messages, $nextreservinfo ) = GetOtherReserves($itemnumber);
> 
>     my $patron = Koha::Patrons->find( $nextreservinfo );
>-    my $name   = $patron ? $patron->surname . ", " . $patron->title . " " . $patron->firstname : '';
>     if ( $messages->{'transfert'} ) {
>         $template->param(
>             itemtitle      => $biblio->title,
>             itembiblionumber => $biblio->biblionumber,
>             iteminfo       => $biblio->author,
>-            name           => $name,
>             patron         => $patron,
>             diffbranch     => 1,
>         );
>@@ -400,7 +398,6 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) {
>     my $reserve    = $messages->{'ResFound'};
>     if ( $reserve ) {
>         my $patron = Koha::Patrons->find( $reserve->{'borrowernumber'} );
>-        my $name = $patron->surname . ", " . $patron->title . " " . $patron->firstname;
>         $template->param(
>             patron => $patron,
>         );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27011: 115291 | 115301 | 115319 | 115523