Attachment 115411 Details for Bug 17229 – Bug 17229: Fix unit test warning

[patch] Bug 17229: Fix unit test warning

Bug-17229-Fix-unit-test-warning.patch (text/plain), 1.32 KB, created by Fridolin Somers on 2021-01-20 08:52:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2021-01-20 08:52:09 UTC

Size: 1.32 KB

patch

obsolete

>From a464640c445e356dbf91889a5e3ef1af480ee1d1 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 20 Jan 2021 09:37:45 +0100
>Subject: [PATCH] Bug 17229: Fix unit test warning
>
>Remove warning :
>t/db_dependent/ILSDI_Services.t .. 3/10 Null value for biblionumber in Item not allowed at /home/koha/src/t/lib/TestBuilder.pm line 387
>
>$biblio_with_no_item is a Koha::Biblio object.
>---
> t/db_dependent/ILSDI_Services.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t
>index 0a13d5b18a..90e26f2628 100755
>--- a/t/db_dependent/ILSDI_Services.t
>+++ b/t/db_dependent/ILSDI_Services.t
>@@ -448,14 +448,14 @@ subtest 'Holds test' => sub {
>     my $item5 = $builder->build({
>         source => 'Item',
>         value => {
>-            biblionumber => $biblio_with_no_item->{biblionumber},
>+            biblionumber => $biblio_with_no_item->biblionumber,
>             damaged => 0,
>         }
>     });
> 
>     $query = new CGI;
>     $query->param( 'patron_id', $expired_borrowernumber);
>-    $query->param( 'bib_id', $biblio_with_no_item->{biblionumber});
>+    $query->param( 'bib_id', $biblio_with_no_item->biblionumber);
>     $query->param( 'item_id', $item5->{itemnumber});
> 
>     $reply = C4::ILSDI::Services::HoldItem( $query );
>-- 
>2.30.0

Actions: View | Diff | Splinter Review

Attachments on bug 17229: 55059 | 55060 | 62036 | 62037 | 67324 | 67325 | 70682 | 70683 | 72970 | 72971 | 85064 | 85065 | 85066 | 85070 | 85071 | 85072 | 85118 | 85883 | 89760 | 99701 | 99702 | 99703 | 99817 | 99818 | 99819 | 113741 | 113742 | 113743 | 115081 | 115082 | 115083 | 115411 | 115435