Attachment 115424 Details for Bug 22773 – Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label

[patch] Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label

Bug-22773-QA-follow-up-Improve-existing-merge-butt.patch (text/plain), 2.70 KB, created by Nick Clemens (kidclamp) on 2021-01-20 12:18:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-01-20 12:18:38 UTC

Size: 2.70 KB

patch

obsolete

>From 5ff98ec8fd0058fb8e4668f2943b71a68790e1e9 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 1 Jul 2020 04:20:48 +0000
>Subject: [PATCH] Bug 22773: (QA follow-up) Improve existing merge button and
> fix checkbox label
>
>Fixes the checkbox label by adding an id, so that when you click on
>"Show only subscriptons" the checkbox will be checked.
>
>Adds standard classes to the existing "Merge selected invoices" button
>to make things more consistent. Also added the fa-compress icon that
>we use in cataloguing on the merge records button.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>index f4c916520a..7d22b4bf99 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>@@ -31,8 +31,8 @@
>             [% ELSE %]
>                 [% SET tab = 'opened' %]
>             [% END %]
>+          <input type="checkbox" style="vertical-align: middle;" id="show_only_subscription" class="show_only_subscription" data-tableid="[% tab %]resultst"/>
>           <label for="show_only_subscription">
>-            <input type="checkbox" style="vertical-align: middle;" class="show_only_subscription" data-tableid="[% tab %]resultst"/>
>             Show only subscriptions
>           </label>
>           <table id="[% tab %]resultst" class="result">
>@@ -114,7 +114,7 @@
>             </tbody>
>           </table>
>           [% IF CAN_user_acquisition_merge_invoices %]
>-              <a class="submit merge" id="merge" href="#merge_invoices">Merge selected invoices</a>
>+   +          <a class="btn btn-default submit merge" id="merge" href="#merge_invoices"><i class="fa fa-compress"></i> Merge selected invoices</a>
>               [% IF tab == 'closed' %]
>                 <a class="btn btn-default" id="open_sel" href="#reopen_selected" data-op="reopen" data-referer="referer=/cgi-bin/koha/acqui/invoices.pl%3Fop=do_search%26invoicenumber=[% invoicenumber | uri %]%26supplier=[% booksellerid | uri %]%26shipmentdatefrom=[% shipmentdatefrom | $KohaDates %]%26shipmentdateto=[% shipmentdateto | $KohaDates %]%26billingdatefrom=[% billingdatefrom | $KohaDates %]%26billingdateto=[% billingdateto | $KohaDates %]%26isbneanissn=[% isbneanissn | uri %]%26title=[% title | uri %]%26author=[% author | uri %]%26publisher=[% publisher | uri %]%26publicationyear=[% publicationyear | uri %]%26branch=[% branch | uri %]"><i class="fa fa-refresh"></i> Reopen selected invoices</a>
>               [% ELSE  %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22773: 93357 | 93375 | 93448 | 93660 | 94411 | 95290 | 96906 | 96907 | 96908 | 96909 | 96910 | 98729 | 98730 | 98731 | 98732 | 98733 | 106538 | 106539 | 106540 | 106541 | 106542 | 106543 | 106544 | 115420 | 115421 | 115422 | 115423 | 115424 | 115425 | 115426 | 116010 | 119282 | 119283 | 119284 | 119285 | 119286 | 119287 | 119288 | 119289 | 119290