Bugzilla – Attachment 115435 Details for
Bug 17229
ILS-DI HoldTitle and HoldItem should check if patron is expired
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17229: Fix perlcritic on ILSDI_Services.t
Bug-17229-Fix-perlcritic-on-ILSDIServicest.patch (text/plain), 936 bytes, created by
Jonathan Druart
on 2021-01-20 14:21:20 UTC
(
hide
)
Description:
Bug 17229: Fix perlcritic on ILSDI_Services.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-01-20 14:21:20 UTC
Size:
936 bytes
patch
obsolete
>From 95863d7690b2d9c2f2b27c51ddaf800558135671 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 20 Jan 2021 15:20:51 +0100 >Subject: [PATCH] Bug 17229: Fix perlcritic on ILSDI_Services.t > >Subroutine "new" called using indirect syntax at line 456, column 14. See page 349 of PBP. (Severity: 4) >--- > t/db_dependent/ILSDI_Services.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index 90e26f2628..3818762e55 100755 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -453,7 +453,7 @@ subtest 'Holds test' => sub { > } > }); > >- $query = new CGI; >+ $query = CGI->new; > $query->param( 'patron_id', $expired_borrowernumber); > $query->param( 'bib_id', $biblio_with_no_item->biblionumber); > $query->param( 'item_id', $item5->{itemnumber}); >-- >2.20.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=115435">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17229
:
55059
|
55060
|
62036
|
62037
|
67324
|
67325
|
70682
|
70683
|
72970
|
72971
|
85064
|
85065
|
85066
|
85070
|
85071
|
85072
|
85118
|
85883
|
89760
|
99701
|
99702
|
99703
|
99817
|
99818
|
99819
|
113741
|
113742
|
113743
|
115081
|
115082
|
115083
|
115411
| 115435