Attachment 115490 Details for Bug 22150 – Bug 22150: (follow-up) ensuring superlibrarian flag not checked when select all

[patch] Bug 22150: (follow-up) ensuring superlibrarian flag not checked when select all

Bug-22150-ensuring-superlibrarian-flag-not-checked.patch (text/plain), 1.34 KB, created by Amy King on 2021-01-21 02:21:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Amy King

Created: 2021-01-21 02:21:35 UTC

Size: 1.34 KB

patch

obsolete

>From b06411bf6934854e5e80feb2fa023ba7334ec03c Mon Sep 17 00:00:00 2001
>From: Amy King <amyking386@gmail.com>
>Date: Thu, 21 Jan 2021 01:51:24 +0000
>Subject: [PATCH] Bug 22150: ensuring superlibrarian flag not checked when
> select all
>
>Test plan:
>1. Go to a patron account page
>2. Click more, set permissions
>3. If you select Superlibrarian, you can't unselect on box.
>4. Apply first patch by Jasmine Amohia
>5. Follow steps for that patch
>6. Apply patch
>7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you
>click "Select all" the Superlibrarian checkbox is not checked
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
>index 14b40228f0..a864c324d5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
>@@ -153,6 +153,7 @@
>             $("#CheckAllFlags").on("click",function(){
>                 $(".flag").attr("disabled", false);
>                 $(".flag").prop("checked", true);
>+                $(".flag:first").prop("checked", false);
>                 return false;
>             });
>             $("#UncheckAllFlags").on("click",function(){
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22150: 84170 | 115490 | 115530 | 115531 | 115594 | 115595 | 115610 | 115611 | 115612 | 115691