Attachment 115520 Details for Bug 27409 – Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2

[patch] Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2

Bug-27409-Update-intranet-tmplprogenmodulesmembers.patch (text/plain), 3.05 KB, created by Martin Renvoize (ashimema) on 2021-01-21 10:19:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-01-21 10:19:14 UTC

Size: 3.05 KB

patch

obsolete

>From b7ac7e87e07c57d70924eb18394baecec7a8fc8b Mon Sep 17 00:00:00 2001
>From: James O'Keeffe <jamespfk@gmail.com>
>Date: Wed, 20 Jan 2021 01:52:03 +0000
>Subject: [PATCH] Bug 27409: Update
> intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2
>
>This patch changes all instances of type="number" in inputs to adhere
>with the ACC2 guidelines
>
>In addition, all "min" and "step" attributes have been removed from
>these inputs (Thanks Owen).
>
>Test plan:
>Go through the boraccount.tt file and insure that no instances of
>type="number" were missed.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/members/boraccount.tt     | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>index 84cde2f3f0..8158b016e9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>@@ -174,7 +174,7 @@
>                                 </li>
>                                 <li>
>                                     <label class="required" for="amount">Returned to patron: </label>
>-                                    <input type="number" step="0.01" id="amount" name="amount" min="0.00" required="required">
>+                                    <input type="text" inputmode="numeric" pattern="[0-9]*" id="amount" name="amount" required="required">
>                                     <span class="required">Required</span>
>                                 </li>
>                                 [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %]
>@@ -243,7 +243,7 @@
>                                 </li>
>                                 <li>
>                                     <label class="required" for="amount">Returned to patron: </label>
>-                                    <input type="number" step="0.01" id="returned" name="amount" min="0.00" required="required">
>+                                    <input type="text" inputmode="numeric" pattern="[0-9]*" id="returned" name="amount" required="required">
>                                     <span class="required">Required</span>
>                                 </li>
>                                 [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %]
>@@ -305,7 +305,7 @@
>                                 </li>
>                                 <li>
>                                     <label class="required" for="amount">Discount to apply: </label>
>-                                    <input type="number" step="0.01" id="discount" name="amount" min="0.00" required="required">
>+                                    <input type="text" inputmode="numeric" pattern="[0-9]*" id="discount" name="amount" required="required">
>                                     <span class="required">Required</span>
>                                 </li>
>                             </ol>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27409: 115397 | 115460 | 115481 | 115520 | 115555