Bugzilla – Attachment 11561 Details for
Bug 8607
overdue_notices is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
SIGNED-OFF-Bug-8607-FIX-overdues_notices-script-date.patch
0002-SIGNED-OFF-Bug-8607-FIX-overdues_notices-script-date.patch (text/plain), 1.78 KB, created by
wajasu
on 2012-08-12 02:22:43 UTC
(
hide
)
Description:
SIGNED-OFF-Bug-8607-FIX-overdues_notices-script-date.patch
Filename:
MIME Type:
Creator:
wajasu
Created:
2012-08-12 02:22:43 UTC
Size:
1.78 KB
patch
obsolete
>From f580070e4d5e7412c6a9abcabb8e39497fdd11f8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 9 Aug 2012 15:40:53 +0200 >Subject: [PATCH 2/2] [SIGNED-OFF]Bug 8607: FIX overdues_notices script: $date > is not replaced >Content-Type: text/plain; charset="utf-8" > >The script is unusable. >The variable $date is not replaced with its content. > >Signed-off-by: wajasu <matted-34813@mypacks.net> >--- > misc/cronjobs/overdue_notices.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 8c0bc12..1243add 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -388,7 +388,7 @@ foreach my $branchcode (@branches) { > > $verbose and warn sprintf "branchcode : '%s' using %s\n", $branchcode, $admin_email_address; > >- my $sth2 = $dbh->prepare( <<'END_SQL' ); >+ my $sth2 = $dbh->prepare( <<"END_SQL" ); > SELECT biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue > FROM issues,items,biblio, biblioitems > WHERE items.itemnumber=issues.itemnumber >@@ -455,10 +455,10 @@ END_SQL > } > $borrower_sql .= ' AND categories.overduenoticerequired=1 '; > if($triggered) { >- $borrower_sql .= ' AND TO_DAYS($date)-TO_DAYS(date_due) = ?'; >+ $borrower_sql .= " AND TO_DAYS($date)-TO_DAYS(date_due) = ?"; > push @borrower_parameters, $mindays; > } else { >- $borrower_sql .= ' AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? ' ; >+ $borrower_sql .= " AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? " ; > push @borrower_parameters, $mindays, $maxdays; > } > >-- >1.7.11.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8607
:
11497
| 11561