Attachment 115613 Details for Bug 27474 – Bug 27474: improve link text when no avaliable printer profiles

[patch] Bug 27474: improve link text when no avaliable printer profiles

Bug-27474-improve-link-text-when-no-avaliable-prin.patch (text/plain), 2.40 KB, created by Nick Clemens (kidclamp) on 2021-01-21 19:51:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-01-21 19:51:32 UTC

Size: 2.40 KB

patch

obsolete

>From e1f323e99e5f8f365e23c0e7eaa29bf5feb78008 Mon Sep 17 00:00:00 2001
>From: Amy King <amyking386@gmail.com>
>Date: Wed, 20 Jan 2021 22:21:21 +0000
>Subject: [PATCH] Bug 27474: improve link text when no avaliable printer
> profiles
>
>Test plan:
>1. Go to tools, click on label creator.
>2. Make sure you have some(1-2) printer profiles free to attach to a
>label template. You can do this by clicking on manage, printer profiles,
>if there is a blank space under the "Template name" header, then it is
>free to attach to a label template.
>3. Click on add new label template.
>4. Note how there is a drop down menu beside "Profile:", to select a
>printer profile.
>5. Assign all of the avaliable printer profiles by making new label templates.
>6. Now woth no avaliable printer profiles, click on add a new label
>template.
>7. Note how there is a drop down menu beside "Profile:" only "No
>Profile/Na" is avaliable to select.
>8. Apply patch.
>9. Repeat steps 2-6.
>10. Now note how there is a link to make a new printer profile, under
>the drop down menu next to "Profile:"
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/labels/label-edit-template.tt     | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-template.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-template.tt
>index 04ecc269d4..071cb64d44 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-template.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-template.tt
>@@ -134,8 +134,10 @@
>                                         </option>
>                                         [% END %]
>                                         </select>
>-                                        [% ELSE %]
>-                                        <a href="/cgi-bin/koha/labels/label-edit-profile.pl?op=new">Click here to define a printer profile.</a>
>+                                        [% END %]
>+                                        [% IF ( profile_list.size == 1 ) %]
>+                                        <br>
>+                                        <a href="/cgi-bin/koha/labels/label-edit-profile.pl?op=new">Make a new printer profile.</a>
>                                         [% END %]
>                                     </li>
>                                 </ol>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27474: 115470 | 115472 | 115593 | 115613 | 115693