Bugzilla – Attachment 11562 Details for
Bug 8621
Template for sending out carts not formatting correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8621: Fix formatting in cart email
Bug-8621-Fix-formatting-in-cart-email.patch (text/plain), 8.57 KB, created by
Katrin Fischer
on 2012-08-12 17:36:20 UTC
(
hide
)
Description:
Bug 8621: Fix formatting in cart email
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2012-08-12 17:36:20 UTC
Size:
8.57 KB
patch
obsolete
>From 8d6efb3b4f2ee488d1c2002576a2b237890b05a8 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 12 Aug 2012 19:33:45 +0200 >Subject: [PATCH] Bug 8621: Fix formatting in cart email > >- Reformatted template for better readability and to find missing element >- Added missing </li> >- Added check for existance of items, so 'Items:' is only printed, if there are items > >To test: >- Add several records to the cart, add items with and without items >- Send yourself the cart as email and check formatting >- Update po files for any language, translate the po file for OPAC > and install language >- Send yourself the cart email again from the translated templates, > check formatting >--- > .../opac-tmpl/prog/en/modules/opac-sendbasket.tt | 208 +++++++++++++------- > 1 file changed, 135 insertions(+), 73 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tt >index 1e7fbca..e5bac00 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tt >@@ -3,90 +3,152 @@ Your cart > <END_SUBJECT> > > [% USE HtmlToText %] >-[% myhtml FILTER html2text(leftmargin => 0, rightmargin => 50) %] >+[% myhtml FILTER html2text(leftmargin => 0, rightmargin => 0) %] > [% myhtmltext | html2text %] > > <HEADER> >+ > [% FILTER html2text %] >-<p>Hi, >-</p> >-<p>[% firstname %] [% surname %] sent you a cart from our online catalog.</p> >+ <p>Hi,</p> >+ >+ <p>[% firstname %] [% surname %] sent you a cart from our online catalog.</p> > >-<p>Please note that the attached file is a MARC bibliographic records file >-which can be imported into personal bibliographic software like EndNote, >-Reference Manager or ProCite.</p> >+ <p>Please note that the attached file is a MARC bibliographic records file >+ which can be imported into personal bibliographic software like EndNote, >+ Reference Manager or ProCite.</p> > [% END %] >+ > <END_HEADER> > > <MESSAGE> > [% FILTER html2text %] >-<hr/> >+ <hr/> > >-[% IF comment %] >-<p>[% comment %]</p> >-<hr/> >-[% END %] >+ [% IF comment %] >+ <p>[% comment %]</p> >+ <hr/> >+ [% END %] > >-<ol> >-[% FOREACH BIBLIO_RESULT IN BIBLIO_RESULTS %] >-<li> >-<a href="[% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber= [% BIBLIO_RESULT.biblionumber %]">[% BIBLIO_RESULT.title %]</a> >-[% IF ( BIBLIO_RESULT.subtitle ) %] [% BIBLIO_RESULT.subtitle %][% END %] >-<ul> >-[% IF ( BIBLIO_RESULT.HASAUTHORS ) %] >-<li>Author(s): [% IF ( BIBLIO_RESULT.author ) %][% BIBLIO_RESULT.author %][% END %][% IF ( BIBLIO_RESULT.MARCAUTHORS ) %][% IF ( BIBLIO_RESULT.author ) %]; [% END %][% FOREACH MARCAUTHOR IN BIBLIO_RESULT.MARCAUTHORS %][% FOREACH MARCAUTHOR_SUBFIELDS_LOO IN MARCAUTHOR.MARCAUTHOR_SUBFIELDS_LOOP %][% MARCAUTHOR_SUBFIELDS_LOO.separator %][% MARCAUTHOR_SUBFIELDS_LOO.value %][% END %][% UNLESS ( loop.last ) %]; [% ELSE %][% END %][% END %][% END %][% END %]</li> >-[% IF ( BIBLIO_RESULT.ISBN ) %] >-<li>ISBN: [% BIBLIO_RESULT.ISBN %]</li> >-[% END %] >-[% IF BIBLIO_RESULT.publishercode %] >-<li> >-Published by: [% BIBLIO_RESULT.publishercode %][% IF ( BIBLIO_RESULT.publicationyear ) %] in [% BIBLIO_RESULT.publicationyear %][% END %][% IF ( BIBLIO_RESULT.pages ) %], [% BIBLIO_RESULT.pages %][% END %][% IF BIBLIO_RESULT.size %], [% BIBLIO_RESULT.size %][% END %] >-</li> >-[% END %] >-[% IF BIBLIO_RESULT.collection %] >-<li>Collection: [% BIBLIO_RESULT.seriestitle %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.subject ) %] >-<li>Subject: [% BIBLIO_RESULT.subject %]<li> >-[% END %] >-[% IF ( BIBLIO_RESULT.copyrightdate ) %] >-<li>Copyright year: [% BIBLIO_RESULT.copyrightdate %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.notes ) %] >-<li>Notes : [% BIBLIO_RESULT.notes %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.unititle ) %] >-<li>Unified title: [% BIBLIO_RESULT.unititle %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.serial ) %] >-<li>Serial: [% BIBLIO_RESULT.serial %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.dewey ) %] >-<li>Dewey: [% BIBLIO_RESULT.dewey %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.classification ) %] >-<li>Classification: [% BIBLIO_RESULT.classification %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.lccn ) %] >-<li>LCCN: [% BIBLIO_RESULT.lccn %]</li> >-[% END %] >-[% IF ( BIBLIO_RESULT.url ) %] >-<li>URL : [% BIBLIO_RESULT.url %]</li> >-[% END %] >-<li>Items: >-<ul> >-[% FOREACH ITEM_RESULT IN BIBLIO_RESULT.ITEM_RESULTS %] >-<li> >-[% ITEM_RESULT.branchname %] >-[% ITEM_RESULT.location %] >-[% IF ITEM_RESULT.itemcallnumber %]([% ITEM_RESULT.itemcallnumber %])[% END %] >-[% ITEM_RESULT.barcode %] >-</li> >-[% END %] >-</ul> >-</ul> >-</li> >-[% END %] >-</ol> >+ <ol> >+ [% FOREACH BIBLIO_RESULT IN BIBLIO_RESULTS %] >+ <li> >+ [% BIBLIO_RESULT.title %] >+ [% IF ( BIBLIO_RESULT.subtitle ) %] [% BIBLIO_RESULT.subtitle %][% END %] >+ <ul> >+ [% IF ( BIBLIO_RESULT.HASAUTHORS ) %] >+ <li>Author(s): [% IF ( BIBLIO_RESULT.author ) %][% BIBLIO_RESULT.author %][% END %] >+ >+ [% IF ( BIBLIO_RESULT.MARCAUTHORS ) %] >+ [% IF ( BIBLIO_RESULT.author ) %]; [% END %] >+ [% FOREACH MARCAUTHOR IN BIBLIO_RESULT.MARCAUTHORS %] >+ [% FOREACH MARCAUTHOR_SUBFIELDS_LOO IN MARCAUTHOR.MARCAUTHOR_SUBFIELDS_LOOP %] >+ [% MARCAUTHOR_SUBFIELDS_LOO.separator %][% MARCAUTHOR_SUBFIELDS_LOO.value %] >+ [% END %] >+ [% UNLESS ( loop.last ) %];[% END %] >+ [% END %] >+ [% END %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.ISBN ) %] >+ <li> >+ ISBN: [% BIBLIO_RESULT.ISBN %] >+ </li> >+ [% END %] >+ >+ [% IF BIBLIO_RESULT.publishercode %] >+ <li> >+ Published by: [% BIBLIO_RESULT.publishercode %] >+ [% IF ( BIBLIO_RESULT.publicationyear ) %] >+ in [% BIBLIO_RESULT.publicationyear %] >+ [% END %] >+ [% IF ( BIBLIO_RESULT.pages ) %] >+ , [% BIBLIO_RESULT.pages %] >+ [% END %] >+ [% IF BIBLIO_RESULT.size %] >+ , [% BIBLIO_RESULT.size %] >+ [% END %] >+ </li> >+ [% END %] >+ >+ [% IF BIBLIO_RESULT.collection %] >+ <li> >+ Collection: [% BIBLIO_RESULT.seriestitle %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.subject ) %] >+ <li> >+ Subject: [% BIBLIO_RESULT.subject %] >+ <li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.copyrightdate ) %] >+ <li> >+ Copyright year: [% BIBLIO_RESULT.copyrightdate %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.notes ) %] >+ <li> >+ Notes : [% BIBLIO_RESULT.notes %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.unititle ) %] >+ <li> >+ Unified title: [% BIBLIO_RESULT.unititle %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.serial ) %] >+ <li> >+ Serial: [% BIBLIO_RESULT.serial %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.dewey ) %] >+ <li> >+ Dewey: [% BIBLIO_RESULT.dewey %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.classification ) %] >+ <li> >+ Classification: [% BIBLIO_RESULT.classification %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.lccn ) %] >+ <li> >+ LCCN: [% BIBLIO_RESULT.lccn %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.url ) %] >+ <li> >+ URL : [% BIBLIO_RESULT.url %] >+ </li> >+ [% END %] >+ >+ [% IF ( BIBLIO_RESULT.ITEM_RESULTS.size ) %] >+ <li>Items: >+ <ul> >+ [% FOREACH ITEM_RESULT IN BIBLIO_RESULT.ITEM_RESULTS %] >+ <li> >+ [% ITEM_RESULT.branchname %] >+ [% ITEM_RESULT.location %] >+ [% IF ITEM_RESULT.itemcallnumber %]([% ITEM_RESULT.itemcallnumber %])[% END %] >+ [% ITEM_RESULT.barcode %] >+ </li> >+ [% END %] >+ </ul> >+ </li> >+ [% END %] >+ </ul> >+ </li> >+ [% END %] >+ </ol> >+ > [% END %] > <END_MESSAGE> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8621
:
11562
|
11593
|
11609