Attachment 115628 Details for Bug 11257 – Bug 11257: PREDUEDST should have more useful default text

[patch] Bug 11257: PREDUEDST should have more useful default text

Bug-11257-PREDUEDST-should-have-more-useful-defaul.patch (text/plain), 1.96 KB, created by Katrin Fischer on 2021-01-21 22:40:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-01-21 22:40:10 UTC

Size: 1.96 KB

patch

obsolete

>From c6f3e00ab435d6277e312feb7db8f37eaaf9149b Mon Sep 17 00:00:00 2001
>From: James O'Keeffe <jamespfk@gmail.com>
>Date: Tue, 19 Jan 2021 22:47:53 +0000
>Subject: [PATCH] Bug 11257: PREDUEDST should have more useful default text
>
>This patch changes the default text of PEDUEDST to the following:
>    Dear <<borrowers.firstname>> <<borrowers.surname>>,
>    The following item(s) will be due soon:
>    <<items.content>>
>
>Note: I dont beleive ive done everything requesting in the bug, ie there
>was a request to add  <<items.content>> to the documentation of
>sample_notices.yml, but I couldn't find documentation for it. If there's
>things I missed, please tell me so I can make the appropraite changes,
>or feel free to make the changes yourself.
>
>Test plan:
>1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools
>        -> Notices and slips)
>2. Open "email", and note the default text.
>3. Apply the patch, and peform a fresh install of Koha.
>4. Navigate to the same page. The default text should have changed.
>
>https://bugs.koha-community.org/show_bug.cgi?id=27237
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> installer/data/mysql/en/mandatory/sample_notices.yml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 22385cac31..97a9291ba8 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -579,7 +579,13 @@ tables:
>           message_transport_type: email
>           lang: default
>           content:
>-            - "You have <<count>> items due soon"
>+            - "Dear <<borrowers.firstname>> <<borrowers.surname>>,"
>+            - ""
>+            - "The following item(s)  will be due soon:"
>+            - ""
>+            - "<<items.content>>"
>+            - ""
>+            - "Thank you."
> 
>         - module: circulation
>           code: RENEWAL
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 11257: 115374 | 115585 | 115625 | 115628 | 115629 | 115630 | 115672 | 115673 | 115674 | 115868 | 115869 | 115870