Bugzilla – Attachment 11564 Details for
Bug 8623
Javascript libraries should be outside theme directories
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8623: Do not accept "lib" as a valid theme
Bug-8623-Do-not-accept-lib-as-a-valid-theme.patch (text/plain), 947 bytes, created by
Jared Camins-Esakov
on 2012-08-13 00:14:51 UTC
(
hide
)
Description:
Bug 8623: Do not accept "lib" as a valid theme
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-08-13 00:14:51 UTC
Size:
947 bytes
patch
obsolete
>From e8b28158925a2c8c854f9baf4c4cca32471bb1c7 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Sun, 12 Aug 2012 20:09:20 -0400 >Subject: [PATCH] Bug 8623: Do not accept "lib" as a valid theme >Content-Type: text/plain; charset="UTF-8" > >Since we are going to be storing third-party Javascript libraries in >koha-tmpl/opac-tmpl/lib and koha-tmpl/intranet-tmpl/lib, we want to make >sure that "lib" is not picked up as a theme in the system preferences >editor. >--- > C4/Koha.pm | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 4f386e4..0e9f4a8 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -674,6 +674,7 @@ sub getallthemes { > opendir D, "$htdocs"; > my @dirlist = readdir D; > foreach my $directory (@dirlist) { >+ next if $directory eq 'lib'; > -d "$htdocs/$directory/en" and push @themes, $directory; > } > return @themes; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8623
:
11564
|
11570
|
11581
|
11582
|
12289
|
12554
|
12555
|
12574
|
12575