Bugzilla – Attachment 115688 Details for
Bug 25552
Add missing Claims Returned option to MarkLostItemsAsReturned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25552: (QA follow-up) Improve claim_returned POD
Bug-25552-QA-follow-up-Improve-claimreturned-POD.patch (text/plain), 1.34 KB, created by
Martin Renvoize (ashimema)
on 2021-01-22 13:01:49 UTC
(
hide
)
Description:
Bug 25552: (QA follow-up) Improve claim_returned POD
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-01-22 13:01:49 UTC
Size:
1.34 KB
patch
obsolete
>From 41b77f0411906711617bdf04c7e0a2600af3febf Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 22 Jan 2021 12:56:02 +0000 >Subject: [PATCH] Bug 25552: (QA follow-up) Improve claim_returned POD > >The POD for the Koha::Checkout->claim_returned method was somewhat >lacking; This patch attempts to explain what the code appears to >achieve. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Checkout.pm | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > >diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm >index 6af0179fe5..04e339136d 100644 >--- a/Koha/Checkout.pm >+++ b/Koha/Checkout.pm >@@ -145,7 +145,17 @@ sub to_api_mapping { > > =head3 claim_returned > >-my $return_claim = $checkout->claim_returned(); >+ my $return_claim = $checkout->claim_returned(); >+ >+This method sets the checkout as claimed return. It will: >+ >+1. Add a new row to the `return_claims` table >+2. Set the item as lost using the 'ClaimReturnedLostValue' >+3. Charge a fee depending on the value of ClaimReturnedChargeFee >+3a. If set to charge, then accruing overdues will be halted >+3b. If set to charge, then any existing transfers will be cancelled >+ and the holding branch will be set back to 'frombranch'. >+4. The issue will be marked as returned as per the 'MarkLostItemsAsReturned' preference > > =cut > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25552
:
105146
|
105389
|
105558
|
105559
|
105643
|
113889
|
113892
|
113893
|
113898
|
115685
|
115686
|
115687
| 115688 |
115689
|
116173