Attachment 115741 Details for Bug 27542 – Bug 27542: Allow cancellation of partner ILL

[patch] Bug 27542: Allow cancellation of partner ILL

Bug-27542-Allow-cancellation-of-partner-ILL.patch (text/plain), 2.10 KB, created by Andrew Isherwood on 2021-01-25 11:22:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2021-01-25 11:22:45 UTC

Size: 2.10 KB

patch

obsolete

>From dd3cad35b835db25a64ac8313f4369e8121919ee Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Mon, 25 Jan 2021 11:18:29 +0000
>Subject: [PATCH] Bug 27542: Allow cancellation of partner ILL
>
>This commit enables the display of the "Revert request" button when a
>request's status is GENREQ / "Requested from partners"
>
>The relevant unit test has also been updated
>---
> Koha/Illrequest.pm           | 4 ++--
> t/db_dependent/Illrequests.t | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 39cf0eabf8..570799fdc7 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -446,11 +446,11 @@ sub _core_status_graph {
>             name           => 'Requested from partners',
>             ui_method_name => 'Place request with partners',
>             method         => 'generic_confirm',
>-            next_actions   => [ 'COMP', 'CHK' ],
>+            next_actions   => [ 'COMP', 'CHK', 'REQREV' ],
>             ui_method_icon => 'fa-send-o',
>         },
>         REQREV => {
>-            prev_actions   => [ 'REQ' ],
>+            prev_actions   => [ 'REQ', 'GENREQ' ],
>             id             => 'REQREV',
>             name           => 'Request reverted',
>             ui_method_name => 'Revert Request',
>diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t
>index 0ed98219e1..082decf130 100755
>--- a/t/db_dependent/Illrequests.t
>+++ b/t/db_dependent/Illrequests.t
>@@ -295,11 +295,11 @@ subtest 'Status Graph tests' => sub {
>             name           => 'Requested from partners',
>             ui_method_name => 'Place request with partners',
>             method         => 'generic_confirm',
>-            next_actions   => [ 'COMP', 'CHK' ],
>+            next_actions   => [ 'COMP', 'CHK', 'REQREV' ],
>             ui_method_icon => 'fa-send-o',
>         },
>         REQREV => {
>-            prev_actions   => [ 'REQ' ],
>+            prev_actions   => [ 'REQ', 'GENREQ' ],
>             id             => 'REQREV',
>             name           => 'Request reverted',
>             ui_method_name => 'Revert Request',
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27542: 115741 | 147897 | 147898 | 147899 | 150641 | 150642 | 150643 | 151458 | 151459 | 151460