Attachment 115797 Details for Bug 27034 – Bug 27034: (follow-up) Remove unneeded params tweak

[patch] Bug 27034: (follow-up) Remove unneeded params tweak

Bug-27034-follow-up-Remove-unneeded-params-tweak.patch (text/plain), 1.14 KB, created by David Nind on 2021-01-25 23:40:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-01-25 23:40:35 UTC

Size: 1.14 KB

patch

obsolete

>From 3dd0d6b77d572a483d0816bb70caa6796ad97490 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 4 Jan 2021 12:23:46 -0300
>Subject: [PATCH] Bug 27034: (follow-up) Remove unneeded params tweak
>
>As $c->objects->search doesn't consider path params anymore, there's no
>need to manually tweak the query parameters.
>
>To test:
>1. Run:
>   $ kshell
>  k$ prove t/db_dependent/api/v1/holds.t
>=> SUCCESS: Tests pass!
>2. Apply this patch
>3. Repeat 1
>=> SUCCESS: Tests still pass!
>4. Sign off :-D
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/REST/V1/Holds.pm | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm
>index 92c2301f83..ee346f6ffe 100644
>--- a/Koha/REST/V1/Holds.pm
>+++ b/Koha/REST/V1/Holds.pm
>@@ -445,8 +445,6 @@ sub pickup_locations {
>     my $c = shift->openapi->valid_input or return;
> 
>     my $hold_id = $c->validation->param('hold_id');
>-    # FIXME: We should really skip the path params in $c->objects->search
>-    delete $c->validation->output->{hold_id};
>     my $hold = Koha::Holds->find( $hold_id, { prefetch => [ 'patron' ] } );
> 
>     unless ($hold) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27034: 114777 | 114806 | 115796 | 115797 | 115805 | 115806