Attachment 115857 Details for Bug 24850 – Bug 24850: (QA follow-up) Add more comments

[patch] Bug 24850: (QA follow-up) Add more comments

Bug-24850-QA-follow-up-Add-more-comments.patch (text/plain), 1001 bytes, created by Martin Renvoize (ashimema) on 2021-01-27 09:19:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-01-27 09:19:28 UTC

Size: 1001 bytes

patch

obsolete

>From 53e38c9c6c9f70aa5c615a26ee1c40edeffa8507 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 27 Jan 2021 09:18:45 +0000
>Subject: [PATCH] Bug 24850: (QA follow-up) Add more comments
>
>To try and clarify the logic here I've added an addition comment to the
>code.
>---
> Koha/DateUtils.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm
>index 09186242ab..882b770c07 100644
>--- a/Koha/DateUtils.pm
>+++ b/Koha/DateUtils.pm
>@@ -123,6 +123,9 @@ sub dt_from_string {
>         /xms;
> 
>         # Default to UTC (when 'Z' is passed) for inbound timezone.
>+        # The regex above succeeds for both 'z', 'Z' and '+/-' offset.
>+        # We set tz as though Z was passed by default and then correct it later if an offset is detected
>+        # by the presence fo the <offset> variable.
>         $tz = DateTime::TimeZone->new( name => 'UTC' );
>     }
>     elsif ( $date_format eq 'iso' or $date_format eq 'sql' ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24850: 100585 | 100586 | 100587 | 100592 | 100593 | 100594 | 100595 | 100678 | 100679 | 100680 | 100681 | 100881 | 100901 | 100902 | 100903 | 100904 | 100905 | 101803 | 101804 | 101805 | 101806 | 101807 | 101808 | 101837 | 101838 | 101839 | 101840 | 101841 | 101842 | 101843 | 101844 | 115851 | 115852 | 115853 | 115854 | 115855 | 115856 | 115857 | 116299 | 116300 | 116301 | 116302 | 116303 | 116304 | 116305 | 116355 | 116356 | 116357 | 116358 | 116359 | 116360 | 116361 | 116511 | 126182 | 126183 | 126184 | 126185 | 126186 | 126187 | 126188 | 126189 | 127231 | 127232 | 127235 | 127236 | 127239 | 127240 | 127241 | 127242 | 127243 | 127244