Attachment 115916 Details for Bug 27251 – Bug 27251: Don't hide the table on delete if empty

[patch] Bug 27251: Don't hide the table on delete if empty

Bug-27251-Dont-hide-the-table-on-delete-if-empty.patch (text/plain), 1.62 KB, created by Katrin Fischer on 2021-01-27 22:36:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-01-27 22:36:01 UTC

Size: 1.62 KB

patch

obsolete

>From bc90f598ce3c6f0b2b807dbac29f4e6afa4761c2 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 6 Jan 2021 10:40:12 +0100
>Subject: [PATCH] Bug 27251: Don't hide the table on delete if empty
>
>If we filtered the result, delete the only row displayed then the table
>was hidden. This is a nice behaviour, especially if there was no filter.
>However we must show it again if the filters are removed.
>I am suggesting to simply to not hide the table and avoid adding more JS
>code to deal with this very specific use case.
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt
>index c42839bfd4..da6b6b6a50 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt
>@@ -215,9 +215,6 @@
>                     }).success(function() {
>                         $("#delete_confirm_modal").modal('hide');
>                         quotes.api().ajax.reload(function (data) {
>-                            if (data.recordsTotal == 0) {
>-                                $("#quotes").hide();
>-                            }
>                             $("#quote_action_result_dialog").hide();
>                             $("#quote_delete_success").html(_("Quote #%s deleted successfully.").format(quote_id)).show();
>                         });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27251: 114435 | 114477 | 114556 | 114832 | 114885 | 114992 | 114993 | 115234 | 115235 | 115236 | 115915 | 115916 | 115917 | 115918 | 115919