Attachment 115986 Details for Bug 23971 – Bug 23971: (follow-up) Remove stale param

[patch] Bug 23971: (follow-up) Remove stale param

Bug-23971-follow-up-Remove-stale-param.patch (text/plain), 1.21 KB, created by Andrew Isherwood on 2021-01-28 16:45:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2021-01-28 16:45:44 UTC

Size: 1.21 KB

patch

obsolete

>From d8af5d2a1a59c6683aa6952210710fff4243be1c Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Tue, 5 Jan 2021 11:34:28 +0000
>Subject: [PATCH] Bug 23971: (follow-up) Remove stale param
>
>As highlighted by Jonathan in comment #90, we were passing
>borrowernumber to ModBasket. This was a hangover from when we explicitly
>logged the borrower, which was later discovered to be unnecessary
>duplication, and was removed in commit "Remove data duplication".
>
>This commit removes this unnecessary parameter.
>---
> acqui/basketgroup.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
>index 962296aa6e..3b53bd9602 100755
>--- a/acqui/basketgroup.pl
>+++ b/acqui/basketgroup.pl
>@@ -307,8 +307,7 @@ if ( $op eq "add" ) {
>   my $basketno=$input->param('basketno');
>   my $basketgroupid=$input->param('basketgroupid');
>   ModBasket( { basketno => $basketno,
>-                         basketgroupid => $basketgroupid,
>-                         borrowernumber => $loggedinuser } );
>+                         basketgroupid => $basketgroupid } );
>   print $input->redirect("basket.pl?basketno=" . $basketno);
> } elsif ( $op eq 'closeandprint') {
> #
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23971: 95285 | 95286 | 95885 | 95888 | 96063 | 96064 | 100239 | 100240 | 100241 | 103911 | 103912 | 103913 | 103945 | 108962 | 111300 | 111301 | 111302 | 111303 | 111304 | 111955 | 111956 | 111957 | 111958 | 111959 | 111960 | 112277 | 112278 | 112279 | 112280 | 112281 | 112282 | 112283 | 112284 | 112285 | 112286 | 112287 | 112288 | 112289 | 112290 | 112291 | 112298 | 112299 | 112300 | 112301 | 112302 | 112303 | 112304 | 112305 | 112306 | 112307 | 113384 | 113385 | 113386 | 113387 | 113388 | 113389 | 113390 | 113391 | 113392 | 113393 | 114857 | 114858 | 114859 | 114860 | 114861 | 114862 | 114863 | 114864 | 114865 | 114866 | 114867 | 114905 | 114906 | 114907 | 114908 | 114909 | 114910 | 114911 | 114912 | 114913 | 114914 | 114915 | 114916 | 115976 | 115977 | 115978 | 115979 | 115980 | 115981 | 115982 | 115983 | 115984 | 115985 | 115986 | 119401 | 119402 | 119403 | 119404 | 119405 | 119406 | 119407 | 119408 | 119409 | 119410 | 119411 | 119412 | 119944 | 119946 | 120048