Attachment 116023 Details for Bug 27068 – Bug 27068: Fix errors in _checkHoldPolicy

[patch] Bug 27068: Fix errors in _checkHoldPolicy

Bug-27068-Fix-errors-in-checkHoldPolicy.patch (text/plain), 2.02 KB, created by Kyle M Hall (khall) on 2021-01-29 12:49:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-01-29 12:49:31 UTC

Size: 2.02 KB

patch

obsolete

>From 9e21aab88802da46b0501ee382c213fdbf8b4a6c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 3 Dec 2020 06:34:33 -0500
>Subject: [PATCH] Bug 27068: Fix errors in _checkHoldPolicy
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/HoldsQueue.pm | 6 +++---
> Koha/Library.pm  | 3 +++
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm
>index e2666aa4ab..d4380ccfa8 100644
>--- a/C4/HoldsQueue.pm
>+++ b/C4/HoldsQueue.pm
>@@ -383,12 +383,12 @@ sub _checkHoldPolicy {
>     my $hold_fulfillment_policy = $item->{hold_fulfillment_policy};
> 
>     return 0 if $hold_fulfillment_policy eq 'holdgroup' && !$library->validate_hold_sibling({branchcode => $request->{branchcode}});
>-    return 0 if $hold_fulfillment_policy eq 'homebranch' && $request->{branchcode} ne $item->$hold_fulfillment_policy;
>-    return 0 if $hold_fulfillment_policy eq 'holdingbranch' && $request->{branchcode} ne $item->$hold_fulfillment_policy;
>+    return 0 if $hold_fulfillment_policy eq 'homebranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy};
>+    return 0 if $hold_fulfillment_policy eq 'holdingbranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy};
> 
>     my $patronLibrary = Koha::Libraries->find($request->{borrowerbranch});
> 
>-    return 0 if $hold_fulfillment_policy eq 'patrongroup' && !patronLibrary->validate_hold_sibling({branchcode => $request->{branchcode}});
>+    return 0 if $hold_fulfillment_policy eq 'patrongroup' && !$patronLibrary->validate_hold_sibling({branchcode => $request->{branchcode}});
> 
>     return 1;
> 
>diff --git a/Koha/Library.pm b/Koha/Library.pm
>index b69fdaaeab..fc2f4f522e 100644
>--- a/Koha/Library.pm
>+++ b/Koha/Library.pm
>@@ -240,6 +240,9 @@ Return if given library is a valid hold group member
> 
> sub validate_hold_sibling {
>     my ( $self, $params ) = @_;
>+
>+    return 1 if $params->{branchcode} eq $self->id;
>+
>     my @hold_libraries = $self->get_hold_libraries;
> 
>     foreach (@hold_libraries) {
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 27068: 113900 | 114125 | 114140 | 114141 | 114142 | 115987 | 116022 | 116023 | 116024 | 116025 | 116026 | 116607 | 116608 | 116609 | 116610 | 116814 | 116815 | 116816 | 116817 | 117215