Attachment 116243 Details for Bug 27600 – Bug 27600: Remove password check from SIP2 renew_all

[patch] Bug 27600: Remove password check from SIP2 renew_all

Bug-27600-Remove-password-check-from-SIP2-renewall.patch (text/plain), 1.22 KB, created by Martin Renvoize (ashimema) on 2021-02-03 10:05:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-03 10:05:42 UTC

Size: 1.22 KB

patch

obsolete

>From cb70cdf7a7a715084ac6584df9cceec9f461d2e5 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 3 Feb 2021 10:03:31 +0000
>Subject: [PATCH] Bug 27600: Remove password check from SIP2 renew_all
>
>This patch removes the password check code from the renew_all method for
>SIP2. This is required, as many units send an empty AD field in the SIP
>message which can cause the transaction to fail.. but the authentication
>should have already taken place earlier in the session.
>---
> C4/SIP/ILS.pm | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm
>index f74045319c..d96ca81787 100644
>--- a/C4/SIP/ILS.pm
>+++ b/C4/SIP/ILS.pm
>@@ -511,15 +511,12 @@ sub renew_all {
>         siplog("LOG_DEBUG", "ILS::renew_all: Invalid patron id: '%s'", $patron_id);
>     }
> 
>-    if (!defined($patron)) {
>+    if (!$patron) {
> 		$trans->screen_msg("Invalid patron barcode.");
> 		return $trans;
>     } elsif (!$patron->renew_ok) {
> 		$trans->screen_msg("Renewals not allowed.");
> 		return $trans;
>-    } elsif (defined($patron_pwd) && !$patron->check_password($patron_pwd)) {
>-		$trans->screen_msg("Invalid patron password.");
>-		return $trans;
>     }
> 
> 	$trans->do_renew_all;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27600: 116243 | 116245 | 116246 | 120266 | 120267 | 120796 | 120797 | 120798 | 120799 | 120829 | 120830