Bugzilla – Attachment 116283 Details for
Bug 27605
Add floating toolbar to patron search page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27605: Add floating toolbar to patron search page
Bug-27605-Add-floating-toolbar-to-patron-search-pa.patch (text/plain), 7.17 KB, created by
Owen Leonard
on 2021-02-03 15:58:22 UTC
(
hide
)
Description:
Bug 27605: Add floating toolbar to patron search page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-02-03 15:58:22 UTC
Size:
7.17 KB
patch
obsolete
>From 479753baca964ad0b62bcc10de25d8ef301b3127 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 3 Feb 2021 15:39:26 +0000 >Subject: [PATCH] Bug 27605: Add floating toolbar to patron search page > >This patch modifies the patron search results page so that the toolbar >with results-related controls "floats" when the user scrolls down. This >gives access to the controls for adding patrons to a list and for >merging patrons. > >Other templates are modified to incorporate a change to the CSS which >changes "#searchheader" to ".searchheader," enabling multiple instances >of a <div> styled with the .searchheader class. > >To test, apply the patch and rebuild the staff interface CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). > > - Go to Patrons in the staff interface. > - Perform a patron search which will return many results. > - Scroll down the page far enough to trigger the floating toolbar. > - Confirm that the toolbar is positioned correctly when paging through > results. > - Confirm that the patron list and merge controls still work correctly. > - Confirm that other pages which used the "#searchheader" id are still > styled correctly: > - Catalog search results > - List contents > - Patron list contents > - Add orders from MARC file >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 2 +- > .../prog/en/modules/acqui/addorderiso2709.tt | 2 +- > .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 15 +++++++++++---- > .../intranet-tmpl/prog/en/modules/patron_lists/list.tt | 2 +- > .../prog/en/modules/virtualshelves/shelves.tt | 2 +- > 6 files changed, 16 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index e250462415..84766fd401 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -2085,7 +2085,7 @@ li { > } > } > >-#searchheader { >+.searchheader { > background-color: #E6F0F2; > border: 1px solid #B9D8D9; > border-radius: 5px 5px 0 0; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >index f27ebfa848..c730d3e1b2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >@@ -46,7 +46,7 @@ > </ul> > > <div id="records_to_import"> >- <div id="searchheader"> >+ <div id="searchheader" class="searchheader"> > <div> > <span class="checkall"><a id="checkAll" href="#">Select all</a></span> > | >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 434f3d0f55..495b7d0eaf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -66,7 +66,7 @@ > [% total | html %] result(s) found [% IF ( query_desc ) %]for <span class="results_query_desc">'[% query_desc | html %]'</span>[% END %][% IF limit_desc %] with limit(s): <span class="results_limit_desc">'[% limit_desc | html %]'</span>[% END %][% IF ( LibraryName ) %] in [% LibraryName | html %] Catalog[% END %]. > </h3> > >- <div id="searchheader"> >+ <div class="searchheader" id="searchheader"> > <div id="selection_ops"> > <a href="#" id="select_all"><i class="fa fa-check"></i> Select all</a> > | >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index 962d7cc3ae..c99294292e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -46,11 +46,9 @@ > [% END %] > > <div id="searchresults"> >- <div id="searchheader"> >- <h3>Patrons found for: <span id="searchpattern">[% IF searchmember %] for '[% searchmember | html %]'[% END %]</span></h3> >- </div> >+ <h3>Patrons found for: <span id="searchpattern">[% IF searchmember %] for '[% searchmember | html %]'[% END %]</span></h3> > [% IF CAN_user_tools_manage_patron_lists || CAN_user_borrowers_edit_borrowers %] >- <div id="searchheader"> >+ <div class="searchheader" id="searchheader"> > <div> > <a href="#" id="select_all"><i class="fa fa-check"></i> Select all</a> > | >@@ -194,6 +192,7 @@ > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'columns_settings.inc' %] > [% INCLUDE 'str/members-menu.inc' %] >+ [% Asset.js("lib/hc-sticky.js") | $raw %] > [% Asset.js("js/members-menu.js") | $raw %] > <script> > $(document).ready(function() { >@@ -312,6 +311,7 @@ > clearFilters(true); > }); > $("#searchform").on("submit", filter); >+ > }); > > var dtMemberResults; >@@ -452,6 +452,13 @@ > 'sPaginationType': 'full_numbers', > "iDisplayLength": [% PatronsPerPage | html %], > "bProcessing": true, >+ "initComplete": function(settings, json) { >+ Sticky = $("#searchheader"); >+ Sticky.hcSticky({ >+ stickTo: "#searchresults", >+ stickyClass: "floating" >+ }); >+ } > }, columns_settings); > update_searched(); > }); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt >index 65f340bd51..3a691aeb62 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt >@@ -104,7 +104,7 @@ > > <form action="list.pl" id="remove_patrons" method="post"> > >- <div id="searchheader"> >+ <div class="searchheader" id="searchheader"> > <span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | > <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span> | > <div class="btn-group"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 3c55406ab2..4fa8c6657f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -142,7 +142,7 @@ > [% END %] > > [% IF itemsloop %] >- <div id="searchheader" class="noprint"> >+ <div id="searchheader" class="searchheader noprint"> > <div id="selection_ops"><span class="checkall"></span> | > <span class="clearall"></span> > >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=116283">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27605
:
116283
|
116289
|
116446
|
116528