Bugzilla – Attachment 116296 Details for
Bug 27610
Accessibility: OPAC - h1 on each page is Logo but should be page description/title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27610: Changed <h1> around logo to <div>
Bug-27610-Changed-h1-around-logo-to-div.patch (text/plain), 1.85 KB, created by
Wainui Witika-Park
on 2021-02-03 22:50:00 UTC
(
hide
)
Description:
Bug 27610: Changed <h1> around logo to <div>
Filename:
MIME Type:
Creator:
Wainui Witika-Park
Created:
2021-02-03 22:50:00 UTC
Size:
1.85 KB
patch
obsolete
>From 32243f5f1619075bdf8d37108ee590a050729006 Mon Sep 17 00:00:00 2001 >From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> >Date: Wed, 3 Feb 2021 22:37:47 +0000 >Subject: [PATCH] Bug 27610: Changed <h1> around logo to <div> > >To test: >1) Look at OPAC and the logo >2) Apply patch >3) Check Koha logo looks the same as before applying the patch >4) Ensure page source shows logo inside <div> and not <h1> > >Sponsored-by: Catalyst IT >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 9436d99e49..df195e20c6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -13,15 +13,15 @@ > <div id="header-region" class="noprint"> > <nav class="navbar navbar-expand"> > <button id="scrolltocontent">Skip to main content</button> >- <h1 id="logo"> >- <a class="navbar-brand" href="/cgi-bin/koha/opac-main.pl"> >- [% IF ( LibraryNameTitle ) %] >- [% LibraryNameTitle | html %] >- [% ELSE %] >- Koha online >- [% END %] >- </a> >- </h1> >+ <div id="logo"> >+ <a class="navbar-brand" href="/cgi-bin/koha/opac-main.pl"> >+ [% IF ( LibraryNameTitle ) %] >+ [% LibraryNameTitle | html %] >+ [% ELSE %] >+ Koha online >+ [% END %] >+ </a> >+ </div> > [% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %] > <div id="cartDetails" class="cart-message">Your cart is empty.</div> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27610
:
116296
|
117017
|
117769
|
117772
|
117773
|
117774
|
117775
|
118084
|
118445
|
118446
|
118447
|
118449
|
118450
|
118451
|
118773
|
118774
|
118775