Attachment 116306 Details for Bug 25777 – Bug 25777: Disable misleading datatables table information display z3950

[patch] Bug 25777: Disable misleading datatables table information display z3950

Bug-25777-Disable-misleading-datatables-table-info.patch (text/plain), 1.66 KB, created by David Cook on 2021-02-04 04:15:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2021-02-04 04:15:27 UTC

Size: 1.66 KB

patch

obsolete

>From 9cae16b62f6507f70ecc1b7bf78a7c74acb49f7a Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 17 Jun 2020 04:34:02 +0000
>Subject: [PATCH] Bug 25777: Disable misleading datatables table information
> display z3950
>
>This patch disables the table information display on z3950_search.pl,
>since it only includes search result counts for that page, which is
>misleading to end users.
>
>To test:
>1) Do not apply the patch
>2) Do a Z39.50 search for "test" against Library of Congress
>3) Note the bottom of the page says "Show 1 to 20 of 20" and
>"Showing page 1 of 501"
>4) Apply the patch and restart Plack
>5) Repeat Step #2
>6) Note the bottom of the page now only says "Showing page 1 of 501"
>7) Note the search bar is gone
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
>index 088b4dafa4..228e94c2d7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
>@@ -246,7 +246,9 @@
>                     { "aTargets": [ 1 ], "sType": "nsb-nse" },
>                 ],
>                 "aaSorting": [[ 1, "asc" ]],
>-                "bPaginate": false
>+                "bPaginate": false,
>+                "searching": false,
>+                "bInfo":false
>             }, columns_settings );
>             InitLastAction();
>         });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25777: 105933 | 115626 | 115787 | 115788 | 116269 | 116270 | 116306 | 116307 | 116391 | 117367