Bugzilla – Attachment 116376 Details for
Bug 24488
Holds to Pull sometimes shows the wrong 'first patron' details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24488: (QA follow-up) Go to next loop as early as possible
Bug-24488-QA-follow-up-Go-to-next-loop-as-early-as.patch (text/plain), 1.69 KB, created by
Marcel de Rooy
on 2021-02-05 10:29:49 UTC
(
hide
)
Description:
Bug 24488: (QA follow-up) Go to next loop as early as possible
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-02-05 10:29:49 UTC
Size:
1.69 KB
patch
obsolete
>From 83fa75d46610cd10c77ff2d1d3c352de6a0b81f2 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Thu, 19 Nov 2020 06:27:49 +0000 >Subject: [PATCH] Bug 24488: (QA follow-up) Go to next loop as early as > possible >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > circ/pendingreserves.pl | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index b7b362fb71..bc7b25b001 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -252,6 +252,11 @@ foreach my $bibnum ( @biblionumbers ){ > > my $hold_info; > my $items = $all_items->{$bibnum}; >+ my $items_count = defined $items ? scalar @$items : 0; >+ my $pull_count = $items_count <= $patrons_count->{$bibnum} ? $items_count : $patrons_count->{$bibnum}; >+ if ( $pull_count == 0 ) { >+ next; >+ } > > # get available item types for each biblio > my @res_itemtypes; >@@ -286,16 +291,12 @@ foreach my $bibnum ( @biblionumbers ){ > $hold_info->{holdingbranches} = [ uniq map { defined $_->holdingbranch ? $_->holdingbranch : () } @$items ]; > > # items available >- my $items_count = scalar @$items; > $hold_info->{items_count} = $items_count; > > # patrons with holds > $hold_info->{patrons_count} = $patrons_count->{$bibnum}; > >- my $pull_count = $items_count <= $patrons_count->{$bibnum} ? $items_count : $patrons_count->{$bibnum}; >- if ( $pull_count == 0 ) { >- next; >- } >+ # number of items to pull > $hold_info->{pull_count} = $pull_count; > > # get other relevant information >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24488
:
97773
|
106379
|
106882
|
107206
|
107213
|
111341
|
111342
|
111343
|
111347
|
111348
|
111349
|
111350
|
111358
|
111359
|
111360
|
111361
|
111362
|
112815
|
112816
|
112817
|
112818
|
112819
|
113695
|
113696
|
113697
|
113698
|
113699
|
113700
|
113756
|
113757
|
113763
|
113764
|
113774
|
113775
|
113776
|
113777
|
113778
|
113798
|
113829
|
113830
|
113831
|
113832
|
113833
|
113834
|
113835
|
113836
|
113837
|
113838
|
113839
|
113840
|
113841
|
113842
|
113850
|
113851
|
113852
|
113853
|
113854
|
113855
|
113856
|
113857
|
113858
|
113859
|
113860
|
113861
|
113862
|
113863
|
113864
|
114835
|
114836
|
114837
|
114838
|
114839
|
114840
|
114841
|
114842
|
114843
|
114844
|
114845
|
114846
|
114847
|
114848
|
114849
|
114850
|
116362
|
116363
|
116364
|
116365
|
116366
|
116367
|
116368
|
116369
|
116370
|
116371
|
116372
|
116373
|
116374
|
116375
| 116376 |
116377
|
116384