Bugzilla – Attachment 11647 Details for
Bug 8617
Problem with display of comments waiting for moderation in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8617 - Problem with display of comments waiting for moderation in OPAC
Bug-8617---Problem-with-display-of-comments-waitin.patch (text/plain), 3.22 KB, created by
Owen Leonard
on 2012-08-16 19:25:08 UTC
(
hide
)
Description:
Bug 8617 - Problem with display of comments waiting for moderation in OPAC
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-08-16 19:25:08 UTC
Size:
3.22 KB
patch
obsolete
>From 294330272b9330e9b5e8dfe39d41d0092e236225 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 16 Aug 2012 15:19:04 -0400 >Subject: [PATCH] Bug 8617 - Problem with display of comments waiting for > moderation in OPAC >Content-Type: text/plain; charset="utf-8" > >This patch addresses on aspect of Bug 8617: The behavior where >live previews of edited comments are displaying on opac-detail >as a duplicate comment. We must pass the review id back to the >script when submitting so that the check for it will evaluate >as true when it should. > >This patch also corrects some JavaScript for translatability. > >To test, submit a comment on a title and approve it. Return to >the title and edit the comment. When you submit your revised >comment the comment pop-up window should close and your revised >comment should appear on opac-detail as "pending approval." >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt >index 6e2b974..6845f6b 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt >@@ -11,7 +11,7 @@ > [% IF ( cgi_debug ) %]alert(_('injecting OLD comment: ')+comment);[% END %] > parent.opener.$('#c[% reviewid %] p').prev("small").prev("h5").html(_("Your edited comment (preview, pending approval)")); > parent.opener.$('#c[% reviewid %] p').html(comment); >- parent.opener.$('#c[% reviewid %] p').append("<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber | uri %]&reviewid=[% reviewid | uri%]\');\">Edit<\/a>"); >+ parent.opener.$('#c[% reviewid %] p').append(" <a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber | uri %]&reviewid=[% reviewid | uri%]\');\">"+_("Edit")+"<\/a>"); > [% END %] > return 1; > }; >@@ -21,7 +21,7 @@ > parent.opener.$('#newcomment').html( > "<h5>" + _("Your comment (preview, pending approval)") + "<\/h5>" + > "<p>"+comment+"<\/p>" + >- "<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber |uri%]\');\">Edit<\/a><\/p>" >+ "<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber |uri%]\');\">"+_("Edit")+"<\/a><\/p>" > ); > parent.opener.$("#addcomment").prev("p").remove(); > parent.opener.$("#addcomment").remove(); >@@ -41,7 +41,6 @@ > window.close(); > [% END %] > [% END %] >- // $('#reviewf').submit(function() {}); > }); > //]]> > </script> >@@ -67,6 +66,7 @@ > [% END %] > <form id="reviewf" action="/cgi-bin/koha/opac-review.pl[% IF ( cgi_debug ) %]?debug=1[% END %]" method="post"> > <input type="hidden" name="biblionumber" value="[% biblionumber | html%]" /> >+ [% IF ( reviewid ) %]<input type="hidden" name="reviewid" value="[% reviewid | html%]" />[% END %] > <fieldset class="brief"> > <legend>Comments on <i>[% title |html %] [% subtitle %]</i>[% IF ( author ) %]by [% author %][% END %]</legend> > <ol><li><textarea id="review" name="review" cols="60" rows="8">[% review %]</textarea></li></ol> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8617
:
11647
|
11720
|
12223